Skip to content

distinguish limit 0 in analyze #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenhao7253886 wants to merge 5 commits into from
Closed

distinguish limit 0 in analyze #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7847566
exchange check error when parent child is union
Dec 18, 2017
433f3b8
can't materialize join's EqJoinPredicates when refereces Subquery's c…
Dec 18, 2017
782f768
can't materialize join's EqJoinPredicates when refereces Subquery's c…
chenhao7253886 Dec 18, 2017
db3d106
Merge branch 'master' of https://github.com/chenhao7253886/palo
Mar 12, 2018
3e33eba
distinguish limit 0 in analyze
Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fe/src/com/baidu/palo/analysis/LimitElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,13 @@ public String toSql() {
sb.append("" + limit);
return sb.toString();
}

public void analyze(Analyzer analyzer) {
if (limit == 0) analyzer.setHasEmptyResultSet();
}

public void reset() {
limit = -1;
offset = 0;
}
}
11 changes: 10 additions & 1 deletion fe/src/com/baidu/palo/analysis/QueryStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,19 @@ public abstract class QueryStmt extends StatementBase {
public void analyze(Analyzer analyzer) throws AnalysisException, InternalException {
if (isAnalyzed()) return;
super.analyze(analyzer);
// analyzeLimit(analyzer);
analyzeLimit(analyzer);
if (hasWithClause()) withClause_.analyze(analyzer);
}

private void analyzeLimit(Analyzer analyzer) throws AnalysisException {
// TODO chenhao
if (limitElement.getOffset() > 0 && !hasOrderByClause()) {
throw new AnalysisException("OFFSET requires an ORDER BY clause: " +
limitElement.toSql().trim());
}
limitElement.analyze(analyzer);
}

/**
* Returns a list containing all the materialized tuple ids that this stmt is
* correlated with (i.e., those tuple ids from outer query blocks that TableRefs
Expand Down
2 changes: 1 addition & 1 deletion fe/src/com/baidu/palo/analysis/SelectStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ public void materializeRequiredSlots(Analyzer analyzer) throws AnalysisException
// can also be safely evaluated below the join (picked up by getBoundPredicates()).
// Such predicates will be marked twice and that is ok.
List<Expr> unassigned =
analyzer.getUnassignedConjuncts(getTableRefIds());
analyzer.getUnassignedConjuncts(getTableRefIds(), true);
List<Expr> unassignedJoinConjuncts = Lists.newArrayList();
for (Expr e: unassigned) {
if (analyzer.evalByJoin(e)) {
Expand Down