Skip to content

Conversation

@cambyzju
Copy link
Contributor

Proposed changes

Issue Number: close ##18036

Problem summary

  1. [vec] cherry-pick [fix](expr) refractor create_tree_from_thrift to avoid stack overflow #18214 to 1.1-lts;
  2. [non-vec] also refractor create_tree_from_thrift in non-vectorized engine;

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@cambyzju cambyzju changed the title [cherry-pick][fix](expr) refractor create_tree_from_thrift to avoid stack overflow [cherry-pick-1.1](fix-expr) refractor create_tree_from_thrift to avoid stack overflow Apr 10, 2023
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@cambyzju
Copy link
Contributor Author

run buildall

@yangzhg yangzhg merged commit 7199b9f into apache:branch-1.1-lts Apr 12, 2023
cambyzju pushed a commit to cambyzju/incubator-doris that referenced this pull request Apr 12, 2023
…d stack overflow (apache#18514)

* cherry-pick pr18214 and also refractor create_tree_from_thrift in non-vectorized engine

* update
cambyzju pushed a commit to cambyzju/incubator-doris that referenced this pull request Apr 12, 2023
…d stack overflow (apache#18514)

* cherry-pick pr18214 and also refractor create_tree_from_thrift in non-vectorized engine

* update
yangzhg pushed a commit that referenced this pull request Apr 13, 2023
…d stack overflow (#18514) (#18597)

* cherry-pick pr18214 and also refractor create_tree_from_thrift in non-vectorized engine
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…d stack overflow (apache#18514) (apache#18597)

* cherry-pick pr18214 and also refractor create_tree_from_thrift in non-vectorized engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.1.6 reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants