Skip to content

Conversation

@kaka11chen
Copy link
Contributor

Proposed changes

Continue work of #18835.

  1. Use decimal V3 type in JDBC and Iceberg tables.
  2. Fix hdfs TVF decimal V3 type and regression test.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

morningman
morningman previously approved these changes Apr 22, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 22, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@kaka11chen kaka11chen force-pushed the multi_catalog_decimal_v3 branch from c8a1afe to f917c29 Compare April 23, 2023 05:13
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 23, 2023
@kaka11chen
Copy link
Contributor Author

run buildall

…odule.

1. Use decimal V3 type in JDBC and Iceberg tables.
2. Fix hdfs TVF decimal V3 type and regression test.
@kaka11chen kaka11chen force-pushed the multi_catalog_decimal_v3 branch from f917c29 to 4281077 Compare April 25, 2023 00:22
@kaka11chen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 61b7a52 into apache:master Apr 25, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 25, 2023
…odule. (apache#18926)

1. Use decimal V3 type in JDBC and Iceberg tables.
2. Fix hdfs TVF decimal V3 type and regression test.
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
…odule. (apache#18926)

1. Use decimal V3 type in JDBC and Iceberg tables.
2. Fix hdfs TVF decimal V3 type and regression test.
@xiaokang xiaokang mentioned this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants