Fixed: add mutex for cpu_info init() #1942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by init() in multi threads.
imay
requested changes
Oct 9, 2019
Contributor
imay
left a comment
imay
left a comment
There was a problem hiding this comment.
I think you don't find the root cause. You'd better look into it again.
| unique_ptr<int[]> CpuInfo::core_to_numa_node_; | ||
| vector<vector<int>> CpuInfo::numa_node_to_cores_; | ||
| vector<int> CpuInfo::numa_node_core_idx_; | ||
| pthread_mutex_t CpuInfo::init_mutex_; |
Contributor
There was a problem hiding this comment.
- we don't need this lock, because CpuInfo is only initialized in main function.
- even if we need a lock, std::mutex is preferred.
- you don't call pthread_mutex_init() to initialize this variable, it will lead process crash.
Contributor
Author
There was a problem hiding this comment.
This problem has been fixed in 1826 with same way, in which use a mutex to lock when init(). So I close this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: add mutex for cpu_info init() to prevent random core dump caused by init() in multi threads.