Skip to content

Conversation

@kangkaisen
Copy link
Contributor

@kangkaisen kangkaisen commented Oct 10, 2019

For #1610

Add a new type: Object. Currently, it's mainly for complex aggregate metrics(HLL , Bitmap).

The Object type has the following constraints:
1 Object type could not as key column type
2 Object type doesn't support all indices (BloomFilter, short key, zone map, invert index)
3 Object type doesn't support filter and group by

In the implementation:

The Object type reuse the StringValue and StringVal, because in storage engine, the Object type is binary, it has a pointer and length.

@kangkaisen
Copy link
Contributor Author

Update.
Use bitmap type in FE and convert to object type in Thrift.

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update correspond document.

@kangkaisen
Copy link
Contributor Author

1 Object type support v1
2 Change the bitmap_union type to bitmap
3 Add check for bitmap_count function
4 Update the doc

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit 95a3b4c into apache:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants