Skip to content

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented May 18, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

1.broker support fqdn

2.change 'master_only' attr of 'enable_fqdn_mode'

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zddr
Copy link
Contributor Author

zddr commented May 18, 2023

run buildall

@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/spark-load Issues or PRs related to the spark load labels May 18, 2023
@morningman morningman self-assigned this May 19, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 19, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

Need to modify FQDN doc, and alter system add broker doc

@morningman morningman merged commit a81db3e into apache:master May 20, 2023
@zddr zddr mentioned this pull request May 23, 2023
3 tasks
@zddr zddr deleted the fqdn_broker branch March 28, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/spark-load Issues or PRs related to the spark load reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants