Skip to content

Conversation

@amorynan
Copy link
Contributor

Proposed changes

support select into outfile for struct type
Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

run buildall

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720
Copy link
Member

xy720 commented May 22, 2023

can you please add some test case?

@amorynan
Copy link
Contributor Author

can you please add some test case?

Done!

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 merged commit 6762af3 into apache:master May 22, 2023
@xy720 xy720 mentioned this pull request May 22, 2023
88 tasks
@xy720 xy720 added area/outfile area/export struct-type Issues or PRs related to struct type kind/feature Categorizes issue or PR as related to a new feature. labels May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/export area/outfile area/vectorization kind/feature Categorizes issue or PR as related to a new feature. kind/test struct-type Issues or PRs related to struct type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants