Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions be/src/olap/rowset/rowset.h
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,14 @@ class Rowset : public std::enable_shared_from_this<Rowset> {
}
}

void update_delayed_expired_timestamp(uint64_t delayed_expired_timestamp) {
if (delayed_expired_timestamp > _delayed_expired_timestamp) {
_delayed_expired_timestamp = delayed_expired_timestamp;
}
}

uint64_t delayed_expired_timestamp() { return _delayed_expired_timestamp; }

virtual Status get_segments_key_bounds(std::vector<KeyBoundsPB>* segments_key_bounds) {
_rowset_meta->get_segments_key_bounds(segments_key_bounds);
return Status::OK();
Expand Down Expand Up @@ -328,6 +336,7 @@ class Rowset : public std::enable_shared_from_this<Rowset> {
std::atomic<uint64_t> _refs_by_reader;
// rowset state machine
RowsetStateMachine _rowset_state_machine;
std::atomic<uint64_t> _delayed_expired_timestamp = 0;
};

} // namespace doris
19 changes: 11 additions & 8 deletions be/src/olap/tablet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -794,14 +794,17 @@ void Tablet::delete_expired_stale_rowset() {
for (auto& timestampedVersion : to_delete_version) {
auto it = _stale_rs_version_map.find(timestampedVersion->version());
if (it != _stale_rs_version_map.end()) {
// delete rowset
StorageEngine::instance()->add_unused_rowset(it->second);
_stale_rs_version_map.erase(it);
VLOG_NOTICE << "delete stale rowset tablet=" << full_name() << " version["
<< timestampedVersion->version().first << ","
<< timestampedVersion->version().second
<< "] move to unused_rowset success " << std::fixed
<< expired_stale_sweep_endtime;
uint64_t now = UnixSeconds();
if (now > it->second->delayed_expired_timestamp()) {
// delete rowset
StorageEngine::instance()->add_unused_rowset(it->second);
_stale_rs_version_map.erase(it);
VLOG_NOTICE << "delete stale rowset tablet=" << full_name() << " version["
<< timestampedVersion->version().first << ","
<< timestampedVersion->version().second
<< "] move to unused_rowset success " << std::fixed
<< expired_stale_sweep_endtime;
}
} else {
LOG(WARNING) << "delete stale rowset tablet=" << full_name() << " version["
<< timestampedVersion->version().first << ","
Expand Down
12 changes: 12 additions & 0 deletions be/src/vec/exec/scan/new_olap_scanner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,18 @@ Status NewOlapScanner::_init_tablet_reader_params(
((NewOlapScanNode*)_parent)->_olap_scan_node.use_topn_opt;
}

// If this is a Two-Phase read query, and we need to delay the release of Rowset
// by rowset->update_delayed_expired_timestamp().This could expand the lifespan of Rowset
if (_tablet_schema->field_index(BeConsts::ROWID_COL) >= 0) {
constexpr static int delayed_s = 60;
for (auto rs_reader : _tablet_reader_params.rs_readers) {
uint64_t delayed_expired_timestamp =
UnixSeconds() + _tablet_reader_params.runtime_state->execution_timeout() +
delayed_s;
rs_reader->rowset()->update_delayed_expired_timestamp(delayed_expired_timestamp);
}
}

return Status::OK();
}

Expand Down