Skip to content

[Bug](CSVReader) fix null pointer coredump in CSVReader in p2 #20811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 1 commit into from
Jul 15, 2023
Merged

[Bug](CSVReader) fix null pointer coredump in CSVReader in p2 #20811

xiaokang merged 1 commit into from
Jul 15, 2023

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Jun 14, 2023 •
edited
Loading

Proposed changes

[Bug fix null pointer coredump in CSVReader in p2]

pr：#21514

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@HappenLee
Copy link
Contributor Author

HappenLee commented Jun 14, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

clang-tidy review says "All clean, LGTM! 👍"

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

PR approved by anyone and no changes requested.

yiguolei
yiguolei previously approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee dismissed stale reviews from yiguolei and BiteTheDDDDt via dd8ff84 June 28, 2023 12:48
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

clang-tidy review says "All clean, LGTM! 👍"

@HappenLee HappenLee changed the title [Refactor](pipeline) change pipeline dependencies to int [Bug](CSVReader) fix null pointer coredump in CSVReader in p2 Jul 14, 2023
@HappenLee
Copy link
Contributor Author

HappenLee commented Jul 14, 2023

run buildall

@HappenLee HappenLee added the dev/2.0.0 2.0.0 release label Jul 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 14, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.6 seconds
stream load tsv: 506 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17169657110 Bytes

xiaokang
xiaokang approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

PR approved by at least one committer and no changes requested.

hubgeter
hubgeter approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@hubgeter hubgeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit a7eb186 into apache:master Jul 15, 2023
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 15, 2023
xiaokang pushed a commit that referenced this pull request Jul 15, 2023
@HappenLee @xiaokang
[Bug](CSVReader) fix null pointer coredump in CSVReader in p2 (#20811)
edceca4
LHG41278 pushed a commit to LHG41278/dorisMine that referenced this pull request Jul 20, 2023
@HappenLee
[Bug](CSVReader) fix null pointer coredump in CSVReader in p2 (apache…
323f2ab 
…#20811)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokang xiaokang xiaokang approved these changes

@morningman morningman morningman approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt left review comments

@yiguolei yiguolei yiguolei left review comments

+1 more reviewer

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/pipeline dev/2.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@HappenLee @hello-stephen @xiaokang @morningman @BiteTheDDDDt @yiguolei @hubgeter