Skip to content

[Enhancement](binlog) Add binlog enable/disable check && filter in Binlog* #22173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 27, 2023
Merged

[Enhancement](binlog) Add binlog enable/disable check && filter in Binlog* #22173

dataroaring merged 1 commit into from
Jul 27, 2023

Conversation

@JackDrogon
Copy link
Contributor

@JackDrogon JackDrogon commented Jul 24, 2023

Proposed changes

Add binlog enable/disable check && filter in Binlog*

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

deadlinefen
deadlinefen approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@deadlinefen deadlinefen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

PR approved by anyone and no changes requested.

@JackDrogon
Copy link
Contributor Author

JackDrogon commented Jul 24, 2023

run buildall

dataroaring
dataroaring previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

PR approved by at least one committer and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 24, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.19 seconds
stream load tsv: 509 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17161939542 Bytes

@xiaokang xiaokang added the dev/2.0.0 2.0.0 release label Jul 25, 2023
@JackDrogon JackDrogon force-pushed the hotfix/binlog_enable branch from 663c7f1 to 5eb619e Compare July 26, 2023 08:11
@JackDrogon
Copy link
Contributor Author

JackDrogon commented Jul 26, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

PR approved by at least one committer and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 26, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.41 seconds
stream load tsv: 532 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17168649775 Bytes

@JackDrogon JackDrogon force-pushed the hotfix/binlog_enable branch from 5eb619e to 3387898 Compare July 26, 2023 09:14
@JackDrogon
Copy link
Contributor Author

JackDrogon commented Jul 26, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 26, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.7 seconds
stream load tsv: 506 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162602528 Bytes

@xiaokang xiaokang added dev/2.0.1 and removed dev/2.0.0 2.0.0 release labels Jul 26, 2023
@JackDrogon JackDrogon force-pushed the hotfix/binlog_enable branch from 3387898 to 84caa99 Compare July 26, 2023 11:31
@JackDrogon
Copy link
Contributor Author

JackDrogon commented Jul 26, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 26, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.89 seconds
stream load tsv: 509 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162317153 Bytes

@JackDrogon
Add binlog enable diable check in BinlogManager
89a146c 
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@JackDrogon JackDrogon force-pushed the hotfix/binlog_enable branch from 84caa99 to 89a146c Compare July 27, 2023 06:23
@JackDrogon
Copy link
Contributor Author

JackDrogon commented Jul 27, 2023

run buildall

dataroaring
dataroaring approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 27, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.2 seconds
stream load tsv: 504 seconds loaded 74807831229 Bytes, about 141 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17167995337 Bytes

@dataroaring dataroaring merged commit 816fd50 into apache:master Jul 27, 2023
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Aug 9, 2023
@JackDrogon @xiaokang
[Enhancement](binlog) Add binlog enable diable check in BinlogManager (…
e1a462d 
…apache#22173)

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
xiaokang pushed a commit that referenced this pull request Aug 11, 2023
@JackDrogon @xiaokang
[Enhancement](binlog) Add binlog enable diable check in BinlogManager (…
a9d7f62 
…#22173)

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@deadlinefen deadlinefen deadlinefen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JackDrogon @hello-stephen @dataroaring @deadlinefen @xiaokang