Skip to content

Conversation

@morningman
Copy link
Contributor

Proposed changes

Reduce from 128MB to 8MB.
So that user can set file_split_size more flexible.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@Jibing-Li Jibing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 31, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.71 seconds
stream load tsv: 508 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17161998611 Bytes

@morningman morningman merged commit 596fd4d into apache:master Aug 3, 2023
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Aug 9, 2023
)

Reduce from 128MB to 8MB.
So that user can set `file_split_size` more flexible.
xiaokang pushed a commit that referenced this pull request Aug 11, 2023
Reduce from 128MB to 8MB.
So that user can set `file_split_size` more flexible.
morningman added a commit to morningman/doris that referenced this pull request Aug 16, 2023
)

Reduce from 128MB to 8MB.
So that user can set `file_split_size` more flexible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants