Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Aug 2, 2023

Proposed changes

  1. refactor call udaf function
  2. support return map type

list
support udf arg map #22059
support udf return map #22300
support udaf arg map #22397
support udaf return map #22508
refactor udaf call #22508

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Mryange Mryange marked this pull request as draft August 2, 2023 10:00
@Mryange
Copy link
Contributor Author

Mryange commented Aug 2, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@Mryange
Copy link
Contributor Author

Mryange commented Aug 3, 2023

run buildall

1 similar comment
@Mryange
Copy link
Contributor Author

Mryange commented Aug 3, 2023

run buildall

@Mryange Mryange marked this pull request as ready for review August 3, 2023 10:15
@Mryange
Copy link
Contributor Author

Mryange commented Aug 3, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.8 seconds
stream load tsv: 512 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17162199408 Bytes

@Mryange
Copy link
Contributor Author

Mryange commented Aug 4, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.16 seconds
stream load tsv: 517 seconds loaded 74807831229 Bytes, about 137 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162475005 Bytes

@Mryange Mryange changed the title [refactor](udaf) refactor call udaf function [refactor](udaf) refactor call udaf function and support map type in return Aug 4, 2023
@Mryange
Copy link
Contributor Author

Mryange commented Aug 6, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.21 seconds
stream load tsv: 514 seconds loaded 74807831229 Bytes, about 138 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162054775 Bytes

@Mryange
Copy link
Contributor Author

Mryange commented Aug 7, 2023

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 768088c into apache:master Aug 9, 2023
Mryange added a commit to Mryange/doris that referenced this pull request Aug 11, 2023
xiaokang pushed a commit that referenced this pull request Aug 11, 2023
[vectorized](udaf) java udaf support with map type (#22397)

[refactor](udaf) refactor call udaf function and support map type in return (#22508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants