[Fix](Partial update) Fix wrong position using in segment writer #22782
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Yukang-Lian
force-pushed
the
Fix_Segment_Writer_Wrong_Pos
branch
from
cccbbb1 to
003a32b
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
PR approved by anyone and no changes requested. |
|
run p0 |
Yukang-Lian
force-pushed
the
Fix_Segment_Writer_Wrong_Pos
branch
from
f980b52 to
1183a58
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
…n merge-on-write unique table (#25071) * pick "[Fix](Partial update) Fix wrong position using in segment writer #22782" * pick "[Enhancement](merge-on-write) use delete bitmap to mark delete for rows with delete sign when sequence column doesn't exist #24011" * pick "[Fix](merge-on-write) Correct the alignment process when the existing rows with same key has marked delete sign #24877"
5 participants
Proposed changes
Issue Number: close #xxx
In the process of writing data from block to the segment by the partial update, there will be three different positions, block_pos, delta_pos and segment_pos, and their relationship is shown in the figure below. This PR fixes the use of the wrong positions.
block segment
2 -> 0
3 -> 1 *
4 -> 2
5 -> 3
Take the behavior example with *, we will add block 2-5 rows to segment 0-3 rows. Here * row block_pos = 3, segment_pos = 1, delta_pos = 3-2 = 1.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc..