-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Bug](exchange) init _instance_to_rpc_ctx on register_sink #22976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
wangbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Proposed changes
F0815 07:39:44.856573 65243 percentile.h:87] Check failed: rhs._num_samples == rhs._num_added (65278 vs. 4278124286) *** Check failure stack trace: *** @ 0x56336b4c70b9 google::LogMessageFatal::~LogMessageFatal() @ 0x56336bb0f675 bvar::detail::PercentileInterval<>::merge<>() @ 0x56336bb0e6db bvar::detail::AgentCombiner<>::reset_all_agents() @ 0x56336bb0e041 bvar::detail::Percentile::reset() @ 0x56336bb19093 bvar::detail::ReducerSampler<>::take_sample() @ 0x56336bb105a9 bvar::detail::SamplerCollector::run() @ 0x56336bb10f89 bvar::detail::SamplerCollector::sampling_thread() @ 0x7eff18771dd5 start_thread @ 0x7eff18f89ead __clone @ (nil) (unknown) 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/liyuanyuan/doris_test/2.0/doris/be/src/common/signal_handler.h:413 1# os::Linux::chained_handler(int, siginfo*, void*) in /opt/jdk1.8.0_211/jre/lib/amd64/server/libjvm.so 2# JVM_handle_linux_signal in /opt/jdk1.8.0_211/jre/lib/amd64/server/libjvm.so 3# signalHandler(int, siginfo*, void*) in /opt/jdk1.8.0_211/jre/lib/amd64/server/libjvm.so 4# 0x00007EFF18EC2280 in /lib64/libc.so.6 5# phmap::priv::raw_hash_set, phmap::Hash, phmap::EqualTo, std::allocator:pipeline::ExchangeRpcContext> > >::drop_deletes_without_resize() at /mnt/disk2/liyuanyuan/doris_test/2.0/doris/thirdparty/installed/include/parallel_hashmap/phmap.h:2055 6# phmap::priv::raw_hash_set, phmap::Hash, phmap::EqualTo, std::allocator:pipeline::ExchangeRpcContext> > >::prepare_insert(unsigned long) at /mnt/disk2/liyuanyuan/doris_test/2.0/doris/thirdparty/installed/include/parallel_hashmap/phmap.h:2199 7# doris::pipeline::ExchangeSinkBuffer::_send_rpc(long) at /mnt/disk2/liyuanyuan/doris_test/2.0/doris/be/src/pipeline/exec/exchange_sink_buffer.cpp:197 8# std::_Function_handler::_M_invoke(std::_Any_data const&, long const&, bool const&, doris::PTransmitDataResult const&, long const&) at /mnt/disk2/liyuanyuan/ldb/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291 9# doris::pipeline::SelfDeleteClosure::Run() at /mnt/disk2/liyuanyuan/doris_test/2.0/doris/be/src/pipeline/exec/exchange_sink_buffer.h:143 10# brpc::Controller::EndRPC(brpc::Controller::CompletionInfo const&) in /opt/doris-service/doris-branch-2.0/be/lib/doris_be 11# brpc::Controller::OnVersionedRPCReturned(brpc::Controller::CompletionInfo const&, bool, int) in /opt/doris-service/doris-branch-2.0/be/lib/doris_be 12# brpc::policy::ProcessRpcResponse(brpc::InputMessageBase*) in /opt/doris-service/doris-branch-2.0/be/lib/doris_be 13# brpc::InputMessenger::InputMessageClosure::~InputMessageClosure() in /opt/doris-service/doris-branch-2.0/be/lib/doris_be 14# brpc::InputMessenger::OnNewMessages(brpc::Socket*) in /opt/doris-service/doris-branch-2.0/be/lib/doris_be 15# brpc::Socket::ProcessEvent(void*) in /opt/doris-service/doris-branch-2.0/be/lib/doris_be 16# bthread::TaskGroup::task_runner(long) in /opt/doris-service/doris-branch-2.0/be/lib/doris_be 17# bthread_make_fcontext in /opt/doris-service/doris-branch-2.0/be/lib/doris_be