Skip to content

[fix](Nereids) non-inner join should not merge dist info #22979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Aug 17, 2023
Merged

[fix](Nereids) non-inner join should not merge dist info #22979

morrySnow merged 1 commit into from
Aug 17, 2023

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Aug 15, 2023

Proposed changes

Issue Number: close #xxx

left join should use left dist info.
right join should use right dist info.
full outer join should return ANY dist info.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

morrySnow commented Aug 15, 2023

run buildall

@morrySnow morrySnow requested a review from jackwener August 15, 2023 03:22
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 15, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.6 seconds
stream load tsv: 538 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162102082 Bytes

@morrySnow morrySnow force-pushed the fix_outer_join_dist branch from 34bc7e9 to b750831 Compare August 15, 2023 10:35
@morrySnow
Copy link
Contributor Author

morrySnow commented Aug 15, 2023

run buildall

@morrySnow morrySnow force-pushed the fix_outer_join_dist branch from b750831 to 0eeabfa Compare August 15, 2023 12:23
@morrySnow morrySnow force-pushed the fix_outer_join_dist branch from 0eeabfa to 2e3b206 Compare August 15, 2023 12:23
@morrySnow
Copy link
Contributor Author

morrySnow commented Aug 15, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 16, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.86 seconds
stream load tsv: 539 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 99.5 seconds inserted 10000000 Rows, about 100K ops/s
storage size: 17162281190 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 11d76d0 into apache:master Aug 17, 2023
@morrySnow morrySnow deleted the fix_outer_join_dist branch August 17, 2023 09:48
xiaokang pushed a commit that referenced this pull request Aug 17, 2023
@morrySnow @xiaokang
[fix](Nereids) non-inner join should not merge dist info (#22979)
811a619 
1. left join should use left dist info.
2. right join should use right dist info.
3. full outer join should return ANY dist info.
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Aug 21, 2023
@morrySnow @airborne12
[fix](Nereids) non-inner join should not merge dist info (apache#22979)
9ca8165 
1. left join should use left dist info.
2. right join should use right dist info.
3. full outer join should return ANY dist info.
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Closed
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Sep 20, 2023
@morrySnow
[fix](Nereids) colocate join could not work well on full outer join
d8bde39 
in previous PR apache#22979, we fix the output deriver of join. But we forgot
to change the util method JoinUtils#shouldColocateJoin to adjust the
change of physical properties derive.
we could not use join distribution type anymore since join could output
any distribute for full outer join.
@morrySnow morrySnow mentioned this pull request Sep 20, 2023
Merged
morrySnow added a commit that referenced this pull request Sep 21, 2023
@morrySnow
[fix](Nereids) colocate join could not work well on full outer join (#…
ce57b99 
…24700)

in previous PR #22979, we fix the output deriver of join. But we forgot
to change the util method JoinUtils#shouldColocateJoin to adjust the
change of physical properties derive.
we could not use join distribution type anymore since join could output
any distribute for full outer join.
xiaokang pushed a commit that referenced this pull request Sep 21, 2023
@morrySnow @xiaokang
[fix](Nereids) colocate join could not work well on full outer join (#…
be3d31e 
…24700)

in previous PR #22979, we fix the output deriver of join. But we forgot
to change the util method JoinUtils#shouldColocateJoin to adjust the
change of physical properties derive.
we could not use join distribution type anymore since join could output
any distribute for full outer join.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@jackwener jackwener Awaiting requested review from jackwener

+1 more reviewer

@keanji-x keanji-x keanji-x approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow @hello-stephen @keanji-x @starocean999 @xiaokang