Skip to content

Conversation

@wsjz
Copy link
Contributor

@wsjz wsjz commented Aug 15, 2023

Proposed changes

add preload-extensions module, put all conflict dependencies to pom.xml in preload-extensions

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@wsjz wsjz changed the title [fix](multi-catalog)fix avro and jdbc scanner dependency [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependency conflicts Aug 17, 2023
@wsjz wsjz changed the title [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependency conflicts [fix](multi-catalog)fix all avro,hudi and jdbc scanner class loader dependencies conflicts Aug 17, 2023
@wsjz
Copy link
Contributor Author

wsjz commented Aug 18, 2023

run buildall

@wsjz
Copy link
Contributor Author

wsjz commented Aug 18, 2023

run external

@wsjz wsjz marked this pull request as ready for review August 18, 2023 09:14
@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.95 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162015008 Bytes

@wsjz
Copy link
Contributor Author

wsjz commented Aug 18, 2023

run external

@wsjz
Copy link
Contributor Author

wsjz commented Aug 18, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.21 seconds
stream load tsv: 535 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17161912511 Bytes

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zy-kkk
Copy link
Member

zy-kkk commented Aug 19, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.83 seconds
stream load tsv: 539 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162330278 Bytes

@wsjz
Copy link
Contributor Author

wsjz commented Aug 19, 2023

run p0

Copy link
Member

@zy-kkk zy-kkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 19, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 5ba505e into apache:master Aug 20, 2023
xiaokang pushed a commit that referenced this pull request Aug 21, 2023
add preload-extensions module, put all conflict dependencies to pom.xml in preload-extensions
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
@wsjz wsjz deleted the fix_avro_jdbc_dep branch March 28, 2024 07:03
@hidataplus
Copy link

what diffrents about "fe/fe-core/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java" and "fe/be-java-extensions/preload-extensions/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java",???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants