Skip to content

[opt](pipeline) Make pipeline fragment context send_report asynchronized #23142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gabriel39 merged 8 commits into from
Sep 28, 2023
Merged

[opt](pipeline) Make pipeline fragment context send_report asynchronized #23142

Gabriel39 merged 8 commits into from
Sep 28, 2023

Conversation

@liutang123
Copy link
Contributor

@liutang123 liutang123 commented Aug 17, 2023 •
edited
Loading

Proposed changes

Issue Number: close #xxx

  1. Add PipelineContextReportExecutor class to do report asyncrinized.
  2. Add FragmentMgr::trigger_pipeline_context_report func to trigger report.
  3. use FragmentMgr::trigger_pipeline_context_report as _report_status_cb of PipelineFragmentContext.
  4. change Status of ReportStatusRequest from reference to constant.
  5. Add exec_status when doing exchange and propagate error info to downstream.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@liutang123 liutang123 force-pushed the pipeline-sync-report branch from e9c319e to 2b51133 Compare August 17, 2023 15:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123
Copy link
Contributor Author

liutang123 commented Aug 17, 2023

run build all

@liutang123 liutang123 force-pushed the pipeline-sync-report branch from 2b51133 to 7a855f2 Compare August 18, 2023 08:14
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123
Copy link
Contributor Author

liutang123 commented Aug 18, 2023

run build all

yiguolei
yiguolei reviewed Aug 19, 2023
View reviewed changes
@liutang123
Copy link
Contributor Author

liutang123 commented Aug 19, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 19, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.94 seconds
stream load tsv: 541 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 35.2 seconds inserted 10000000 Rows, about 284K ops/s
storage size: 17162169795 Bytes

@liutang123
Copy link
Contributor Author

liutang123 commented Aug 19, 2023

run p0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123
Copy link
Contributor Author

liutang123 commented Aug 20, 2023

run p0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123
Copy link
Contributor Author

liutang123 commented Aug 21, 2023

run p0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123
Copy link
Contributor Author

liutang123 commented Aug 21, 2023

run p0

@liutang123 liutang123 force-pushed the pipeline-sync-report branch from 3891684 to 776dedd Compare August 21, 2023 13:26
@liutang123
Copy link
Contributor Author

liutang123 commented Aug 21, 2023

run p0

@liutang123 liutang123 self-assigned this Aug 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123 liutang123 force-pushed the pipeline-sync-report branch from 776dedd to ec727e8 Compare August 21, 2023 14:12
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123
Copy link
Contributor Author

liutang123 commented Aug 21, 2023

run p0

@liutang123 liutang123 force-pushed the pipeline-sync-report branch from ec727e8 to 977d03d Compare August 22, 2023 02:24
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123
Copy link
Contributor Author

liutang123 commented Aug 22, 2023

run buildall

@liutang123 liutang123 force-pushed the pipeline-sync-report branch from 977d03d to 2ac0696 Compare August 22, 2023 03:40
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liutang123 liutang123 force-pushed the pipeline-sync-report branch from 2ac0696 to f62d016 Compare August 22, 2023 06:46
@doris-robot
Copy link

doris-robot commented Sep 26, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.99 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162569697 Bytes

@liutang123
Copy link
Contributor Author

liutang123 commented Sep 27, 2023

run buildall

@liutang123
Copy link
Contributor Author

liutang123 commented Sep 27, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 27, 2023

TeamCity be ut coverage result:
Function Coverage: 36.31% (8139/22413)
Line Coverage: 28.47% (65156/228852)
Region Coverage: 27.43% (33784/123155)
Branch Coverage: 24.09% (17244/71574)
Coverage Report: http://coverage.selectdb-in.cc/coverage/341700e70885d82b919ffca74372f9704fb56640_341700e70885d82b919ffca74372f9704fb56640/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 27, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.52 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162349515 Bytes

@liutang123
Copy link
Contributor Author

liutang123 commented Sep 27, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Sep 27, 2023

TeamCity be ut coverage result:
Function Coverage: 36.30% (8134/22410)
Line Coverage: 28.45% (65098/228788)
Region Coverage: 27.40% (33728/123101)
Branch Coverage: 24.06% (17214/71532)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3839fc6e7788d659ee599e8664214badfe3baf94_3839fc6e7788d659ee599e8664214badfe3baf94/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 27, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.03 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162059357 Bytes

HappenLee
HappenLee reviewed Sep 28, 2023
View reviewed changes
be/src/runtime/runtime_state.cpp
}

Status RuntimeState::query_status() {
auto st = _query_ctx->exec_status();
Copy link
Contributor

@HappenLee HappenLee Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why RETURN_IF_ERROR(_query_ctx->exec_status());

Copy link
Contributor Author

@liutang123 liutang123 Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When canceling pipeline fragment context or updating the status of pipeline fragment context, query context will be changed at the same time.
We use this status to try_close or close sink.

HappenLee
HappenLee approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

PR approved by anyone and no changes requested.

Gabriel39
Gabriel39 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 merged commit 864a0f9 into apache:master Sep 28, 2023
vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
@liutang123 @vinlee19
[opt](pipeline) Make pipeline fragment context send_report asynchroni…
b9eb3a7 
…zed (apache#23142)
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@HappenLee HappenLee HappenLee approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees

@liutang123 liutang123

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liutang123 @hello-stephen @doris-robot @yiguolei @HappenLee @Gabriel39