Skip to content

Conversation

@wsjz
Copy link
Contributor

@wsjz wsjz commented Aug 18, 2023

Proposed changes

there are some incompatible issues when use s3 endpoint but use oss,obs,cos location, fix them.
fix #22784

When s3 endpoint in catalog properties or load properties:
"s3.endpoint=cos.mycloud.com"
we can se its value is to access cos.

And then, when the query location is "s3://bucket/key" , we should use s3 client, and fit it with the s3 properties.
For another, when the query location is "cosn://bucket/key" , we should use cos client, and fit it with the cos properties.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xiaokang
Copy link
Contributor

run buildall

1 similar comment
@wsjz
Copy link
Contributor Author

wsjz commented Aug 18, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.91 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162015210 Bytes

@wsjz
Copy link
Contributor Author

wsjz commented Aug 18, 2023

run fe ut

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 18, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit b6dd56f into apache:master Aug 18, 2023
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request Aug 21, 2023
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
@wsjz wsjz deleted the fix_s3_compb branch March 28, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants