Skip to content

[fix](hive) do not split compress data file and support lz4/snappy block codec #23245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 12 commits into from
Aug 26, 2023
Merged

[fix](hive) do not split compress data file and support lz4/snappy block codec #23245

morningman merged 12 commits into from
Aug 26, 2023

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Aug 21, 2023 •
edited
Loading

Proposed changes

  1. do not split compress data file
    Some data file in hive is compressed with gzip, deflate, etc.
    These kinds of file can not be splitted.

  2. Support lz4 block codec
    for hive scan node, use lz4 block codec instead of lz4 frame codec

  3. Support snappy block codec
    For hadoop snappy

  4. Optimize the count(*) query of csv file
    For query like select count(*) from tbl, only need to split the line, no need to split the column.

Need to pick to branch-2.0 after this PR: #22304

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Jibing-Li
Jibing-Li approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Jibing-Li Jibing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor Author

morningman commented Aug 22, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman morningman changed the title [fix](hive) do not split compress data file [fix](hive) do not split compress data file and support lz4 block codec Aug 22, 2023
@morningman morningman force-pushed the not_split_compress_file branch from 3cd8a91 to f838049 Compare August 22, 2023 08:54
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor Author

morningman commented Aug 22, 2023

run buildall

Jibing-Li
Jibing-Li approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@Jibing-Li Jibing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kaka11chen
kaka11chen approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor Author

morningman commented Aug 22, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor Author

morningman commented Aug 23, 2023

run buildall

@morningman morningman force-pushed the not_split_compress_file branch from 12efedc to a140a97 Compare August 23, 2023 14:58
@morningman
Copy link
Contributor Author

morningman commented Aug 23, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman morningman force-pushed the not_split_compress_file branch from a140a97 to e71ca52 Compare August 24, 2023 10:15
@morningman
Copy link
Contributor Author

morningman commented Aug 24, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor Author

morningman commented Aug 24, 2023

run buildall

@morningman morningman force-pushed the not_split_compress_file branch from e71ca52 to d61ce86 Compare August 25, 2023 00:50
@morningman
Copy link
Contributor Author

morningman commented Aug 25, 2023

run buildall

@morningman morningman force-pushed the not_split_compress_file branch from d61ce86 to d526979 Compare August 25, 2023 04:09
@morningman
Copy link
Contributor Author

morningman commented Aug 25, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor Author

morningman commented Aug 25, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor Author

morningman commented Aug 26, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 26, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.95 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162176070 Bytes

@morningman morningman changed the title [fix](hive) do not split compress data file and support lz4 block codec [fix](hive) do not split compress data file and support lz4/snappy block codec Aug 26, 2023
yiguolei
yiguolei approved these changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 40be6a0 into apache:master Aug 26, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2023

PR approved by at least one committer and no changes requested.

morningman added a commit to morningman/doris that referenced this pull request Aug 26, 2023
@morningman
[fix](hive) do not split compress data file and support lz4/snappy bl…
07113e0 
…ock codec (apache#23245)

1. do not split compress data file
Some data file in hive is compressed with gzip, deflate, etc.
These kinds of file can not be splitted.

2. Support lz4 block codec
for hive scan node, use lz4 block codec instead of lz4 frame codec

4. Support snappy block codec
For hadoop snappy

5. Optimize the `count(*)` query of csv file
For query like `select count(*) from tbl`, only need to split the line, no need to split the column.

Need to pick to branch-2.0 after this PR: apache#22304
@morningman morningman mentioned this pull request Aug 26, 2023
Merged
xiaokang pushed a commit that referenced this pull request Aug 26, 2023
@morningman @zzzzzzzs
[fix](hive) do not split compress data file and support lz4/snappy bl…
fd8882b 
…ock codec (#23245) (#23526)

* [Refactor](load) Extract load public code (#22304)

* [fix](hive) do not split compress data file and support lz4/snappy block codec (#23245)

1. do not split compress data file
Some data file in hive is compressed with gzip, deflate, etc.
These kinds of file can not be splitted.

2. Support lz4 block codec
for hive scan node, use lz4 block codec instead of lz4 frame codec

4. Support snappy block codec
For hadoop snappy

5. Optimize the `count(*)` query of csv file
For query like `select count(*) from tbl`, only need to split the line, no need to split the column.

Need to pick to branch-2.0 after this PR: #22304

---------

Co-authored-by: zzzzzzzs <1443539042@qq.com>
tudouzhao pushed a commit to tudouzhao/doris that referenced this pull request Aug 26, 2023
@morningman
[fix](hive) do not split compress data file and support lz4/snappy bl…
821f9b2 
…ock codec (apache#23245)

1. do not split compress data file
Some data file in hive is compressed with gzip, deflate, etc.
These kinds of file can not be splitted.

2. Support lz4 block codec
for hive scan node, use lz4 block codec instead of lz4 frame codec

4. Support snappy block codec
For hadoop snappy

5. Optimize the `count(*)` query of csv file
For query like `select count(*) from tbl`, only need to split the line, no need to split the column.

Need to pick to branch-2.0 after this PR: apache#22304
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaka11chen kaka11chen kaka11chen approved these changes

@yiguolei yiguolei yiguolei approved these changes

@Jibing-Li Jibing-Li Jibing-Li approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morningman @hello-stephen @kaka11chen @yiguolei @Jibing-Li @xiaokang