Skip to content

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Aug 22, 2023

Proposed changes

Issue Number: close #xxx

  • add config enable_col_auth to temporarily disable column permissions(because old/new planner has bug when select from view)
  • Restore the old optimizer to the previous authentication method
  • Support for new optimizer authentication(Legacy issue: When querying the view, the permissions of the base table will be authenticated. The view's own permissions should be authenticated and processed after the new optimizer is improved)
  • fix: show grants for non-existent users
  • fix: role:admin can not grant/revoke to/from user

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zddr
Copy link
Contributor Author

zddr commented Aug 22, 2023

run buildall

@zddr
Copy link
Contributor Author

zddr commented Aug 22, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.75 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162170708 Bytes

@zddr
Copy link
Contributor Author

zddr commented Aug 22, 2023

run buildall

@zddr
Copy link
Contributor Author

zddr commented Aug 22, 2023

run buildall

@zddr
Copy link
Contributor Author

zddr commented Aug 22, 2023

run p0

"Whether to use mysql's bigint type to return Doris's largeint type"})
public static boolean use_mysql_bigint_for_largeint = false;

@ConfField(description = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master_only=true

Copy link
Member

@zy-kkk zy-kkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 24, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

1 similar comment
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 6a49769 into apache:master Aug 24, 2023
xiaokang pushed a commit that referenced this pull request Aug 25, 2023
- add config `enable_col_auth` to temporarily disable column permissions(because old/new planner has bug when select from view)
- Restore the old optimizer to the previous authentication method
- Support for new optimizer authentication(Legacy issue: When querying the view, the permissions of the base table will be authenticated. The view's own permissions should be authenticated and processed after the new optimizer is improved)
- fix: show grants for non-existent users
- fix: role:`admin` can not grant/revoke to/from user
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
924060929 added a commit that referenced this pull request Feb 23, 2024
… the view (#31289)

move UserAuthentication in BindRelation, support check authorization view but skip check in the view

relate pr: #23295
feiniaofeiafei pushed a commit to feiniaofeiafei/doris that referenced this pull request Feb 23, 2024
… the view (apache#31289)

move UserAuthentication in BindRelation, support check authorization view but skip check in the view

relate pr: apache#23295
yiguolei pushed a commit that referenced this pull request Feb 23, 2024
… the view (#31289)

move UserAuthentication in BindRelation, support check authorization view but skip check in the view

relate pr: #23295
@zddr zddr deleted the disable_colauth branch March 28, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged merge_conflict p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants