Skip to content

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Aug 22, 2023

Proposed changes

Support alter colocate group's replica allocation.

  1. SQL command: ALTER COLOCATE GROUP [database.]group SET ("replication_allocation" = "...").

  2. Colocate group belongs to a database, but if its name starts with __global__, then it's a global group, and does not belong to any database;

  3. After alter group schema's replica allocations, also modify all the group's related tables's propertities default.replication_allocation and dynamic.replication_allocation, also modify all the table's existing partitions's replica allocations;

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yujun777
Copy link
Contributor Author

run buildall

@yujun777 yujun777 force-pushed the feat-alter-colocate-group branch from 4c62368 to a8a6839 Compare September 4, 2023 00:41
@yujun777 yujun777 force-pushed the feat-alter-colocate-group branch from af0935e to 2b535cd Compare September 23, 2023 02:27
@yujun777
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.82 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162009945 Bytes

@yujun777
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.71 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17161897242 Bytes

@yujun777 yujun777 force-pushed the feat-alter-colocate-group branch from 1b76505 to e42714a Compare September 23, 2023 15:27
@yujun777
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.52 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162437241 Bytes

@dataroaring dataroaring force-pushed the feat-alter-colocate-group branch from e42714a to d2ba0a6 Compare September 25, 2023 03:57
@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.21 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162243833 Bytes

@yujun777 yujun777 force-pushed the feat-alter-colocate-group branch from d2ba0a6 to 682dbb5 Compare September 26, 2023 07:58
@yujun777
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.33 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161847329 Bytes

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit e9eaf49 into apache:master Sep 26, 2023
vinlee19 pushed a commit to vinlee19/doris that referenced this pull request Oct 7, 2023
xiaokang added a commit that referenced this pull request Oct 23, 2023
@xiaokang xiaokang added dev/2.0.3 kind/meta-version-change Categorizes issue or PR as related to changing meta version and removed dev/2.0.3-merged labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/meta-version-change Categorizes issue or PR as related to changing meta version merge_conflict reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants