Skip to content

[Fix](multi-catalog) Fix hive incorrect result by disable string dict filter if exprs contain null expr. #23361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Aug 25, 2023
Merged

[Fix](multi-catalog) Fix hive incorrect result by disable string dict filter if exprs contain null expr. #23361

morningman merged 1 commit into from
Aug 25, 2023

Conversation

@kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Aug 23, 2023

Proposed changes

Issue Number: close #21960

Fix hive incorrect result by disable string dict filter if exprs contain null expr.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

@kaka11chen kaka11chen force-pushed the fix_string_dict_null_expr_issue branch from 079ffd8 to 9762303 Compare August 23, 2023 05:39
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

@kaka11chen
Copy link
Contributor Author

kaka11chen commented Aug 23, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 23, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.76 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162304530 Bytes

morningman
morningman previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

PR approved by anyone and no changes requested.

@kaka11chen kaka11chen force-pushed the fix_string_dict_null_expr_issue branch from 9762303 to 55db1b2 Compare August 23, 2023 15:47
@kaka11chen
Copy link
Contributor Author

kaka11chen commented Aug 23, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

@kaka11chen kaka11chen force-pushed the fix_string_dict_null_expr_issue branch from 55db1b2 to 95e55ac Compare August 24, 2023 15:47
@kaka11chen
Copy link
Contributor Author

kaka11chen commented Aug 24, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 24, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.5 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17161894641 Bytes

xiaokang
xiaokang approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 25, 2023
@zhangguoqiang666
Copy link
Contributor

zhangguoqiang666 commented Aug 25, 2023

run external

@morningman morningman merged commit 2927377 into apache:master Aug 25, 2023
xiaokang pushed a commit that referenced this pull request Aug 25, 2023
@kaka11chen @xiaokang
[Fix](multi-catalog) Fix hive incorrect result by disable string dict…
1006a78 
… filter if exprs contain null expr. (#23361)

Issue Number: close #21960

Fix hive incorrect result by disable string dict filter if exprs contain null expr.
tudouzhao pushed a commit to tudouzhao/doris that referenced this pull request Aug 26, 2023
@kaka11chen
[Fix](multi-catalog) Fix hive incorrect result by disable string dict…
4b732c7 
… filter if exprs contain null expr. (apache#23361)

Issue Number: close apache#21960

Fix hive incorrect result by disable string dict filter if exprs contain null expr.
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokang xiaokang xiaokang approved these changes

@morningman morningman morningman left review comments

+1 more reviewer

@zddr zddr zddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Hive catalog query result not right

6 participants

@kaka11chen @hello-stephen @zhangguoqiang666 @xiaokang @morningman @zddr