-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](common) implement the move assignment operator for Status #23372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Status's move assignment operator is a default function, which can't move the unique pointer of_err_msgcorrectly, and_err_msgmay be an uninitialized pointer when assigningOK.In the process of return value optimization, the move assignment operator will be called, so the following error is thrown when initializing the
BE's file cache:Where
*status = cache->initialize()will call the move assignment operator, but_err_msgis not a nullptr with unexpected value.Complete Error Stack in GDB
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...