-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve](Status) Add new status codeKEY_NOT_FOUND and KEY_ALREADY_EXISTS for merge on write
#23619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89fc98a to
024e354
Compare
|
run buildall |
Yukang-Lian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…_EXISTS` for merge on write (#23619)
Proposed changes
For merge on write table, when loading data, it will call
lookup_row_keyto find if there exists a row with the same key as the inserted row. The return value oflookup_row_keycan be one ofStatus::NotFound/Status::AlreadyExist/Status::OK. Currently, call toStatus::NotFound/Status::AlreadyExistwill lead to printing stacktrace info. However, the number of call toStatus::NotFound/Status::AlreadyExistcan be up to the number of rows inserted times the number segments of the tablet in the worst case. So it may print lots of useless stacktrace info when loading data. So this PR add two new status code for this scenarios to eliminate printing these useless stacktrace info.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...