Skip to content

[Fix](BinaryPrefixPage) stop to read values when current pos reached the end of the page in BinaryPrefixPageDecoder::next_batch #23855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 7 commits into from
Sep 6, 2023
Merged

[Fix](BinaryPrefixPage) stop to read values when current pos reached the end of the page in BinaryPrefixPageDecoder::next_batch #23855

zhannngchen merged 7 commits into from
Sep 6, 2023

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Sep 4, 2023

Proposed changes

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 4, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 4, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.34 seconds
stream load tsv: 531 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17161893700 Bytes

yiguolei
yiguolei reviewed Sep 5, 2023
View reviewed changes
@bobhan1 bobhan1 force-pushed the fix-BinaryPrefixPage branch 4 times, most recently from 118acbd to 6867914 Compare September 5, 2023 06:31
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen reviewed Sep 5, 2023
View reviewed changes
@bobhan1 bobhan1 force-pushed the fix-BinaryPrefixPage branch from 6867914 to 885eef8 Compare September 5, 2023 06:44
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen requested a review from yiguolei September 5, 2023 07:06
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 5, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 5, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.08 seconds
stream load tsv: 528 seconds loaded 74807831229 Bytes, about 135 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162052827 Bytes

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 6, 2023
@bobhan1 bobhan1 requested a review from zhannngchen September 6, 2023 01:31
@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 6, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

PR approved by at least one committer and no changes requested.

yiguolei
yiguolei reviewed Sep 6, 2023
View reviewed changes
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 6, 2023
@bobhan1 bobhan1 force-pushed the fix-BinaryPrefixPage branch from 2c3661e to 8a3d1d8 Compare September 6, 2023 03:13
@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 6, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 6, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.24 seconds
stream load tsv: 530 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162093084 Bytes

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 6, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 6, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.86 seconds
stream load tsv: 531 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161985243 Bytes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 6, 2023
yiguolei
yiguolei approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 95ae537 into apache:master Sep 6, 2023
xiaokang pushed a commit that referenced this pull request Sep 7, 2023
@bobhan1 @xiaokang
[Fix](BinaryPrefixPage) stop to read values when current pos reached …
2fa15cc 
…the end of the page in `BinaryPrefixPageDecoder::next_batch` (#23855)
@bobhan1 bobhan1 mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bobhan1 @hello-stephen @doris-robot @yiguolei @zhannngchen @xiaokang