[BUG](view) fix can't create view with lambda function #23942
Conversation
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
| sb.append("("); | ||
| int childSize = children.size(); | ||
| Expr lastExpr = getChild(childSize - 1); | ||
| boolean lastIsLambdaExpr = (lastExpr instanceof LambdaFunctionExpr); |
There was a problem hiding this comment.
add comment for the code, trickly here
| // array_filter(array, boolean) only implement as lambda function | ||
| // eg: SELECT array_filter(`array_d`, array_map(x -> (x >= 1), `array_d`)) | ||
| // can't as a normal function for BE, need handle by lambda function call expr | ||
| if (fnName.getFunction().equalsIgnoreCase("array_filter")) { |
There was a problem hiding this comment.
better BE support function "array_filter" as function call
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
zhangstar333
force-pushed
the
fix_compile
branch
from
dbd2758 to
c67cd23
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
before the lambda function Expr not implement toSqlImpl() function. so it's call parent function, which is not suit for lambda function. and will be have error when create view.
before the lambda function Expr not implement toSqlImpl() function. so it's call parent function, which is not suit for lambda function. and will be have error when create view.
7 participants
Proposed changes
before the lambda function Expr not implement toSqlImpl() function.
so it's call parent function, which is not suit for lambda function.
and will be have error when create view.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...