Skip to content

[schedule](pipeline) Remove wait schedule time in pipeline query engine #23994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 3 commits into from
Sep 10, 2023
Merged

[schedule](pipeline) Remove wait schedule time in pipeline query engine #23994

yiguolei merged 3 commits into from
Sep 10, 2023

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Sep 6, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

PR approved by anyone and no changes requested.

@HappenLee
Copy link
Contributor Author

HappenLee commented Sep 6, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 6, 2023

TeamCity be ut coverage result:
Function Coverage: 37.02% (7888/21308)
Line Coverage: 28.94% (63146/218173)
Region Coverage: 27.88% (32832/117758)
Branch Coverage: 24.41% (16840/68982)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d9b36e20b76edb62eee2ef8d611cd518720aea37_d9b36e20b76edb62eee2ef8d611cd518720aea37/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 6, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.26 seconds
stream load tsv: 537 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162002046 Bytes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@HappenLee
Copy link
Contributor Author

HappenLee commented Sep 7, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 7, 2023

TeamCity be ut coverage result:
Function Coverage: 36.99% (7891/21331)
Line Coverage: 28.94% (63237/218506)
Region Coverage: 27.89% (32888/117931)
Branch Coverage: 24.46% (16892/69062)
Coverage Report: http://coverage.selectdb-in.cc/coverage/38ecc946aee0d86df6f5bc65e91dd2e7fe3a8c44_38ecc946aee0d86df6f5bc65e91dd2e7fe3a8c44/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 7, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.11 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161854680 Bytes

@HappenLee
Copy link
Contributor Author

HappenLee commented Sep 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Sep 7, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.85 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162120740 Bytes

@doris-robot
Copy link

doris-robot commented Sep 7, 2023

TeamCity be ut coverage result:
Function Coverage: 37.02% (7887/21306)
Line Coverage: 29.03% (63334/218177)
Region Coverage: 27.93% (32885/117732)
Branch Coverage: 24.51% (16893/68928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e4c3940116a9aa6bb2be2d01cde09b414bdd8957_e4c3940116a9aa6bb2be2d01cde09b414bdd8957/report/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@HappenLee
Copy link
Contributor Author

HappenLee commented Sep 8, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 8, 2023

TeamCity be ut coverage result:
Function Coverage: 36.92% (7895/21386)
Line Coverage: 28.93% (63357/219026)
Region Coverage: 27.87% (32893/118028)
Branch Coverage: 24.45% (16893/69088)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3fa3a1fd8193e76ffb7a3caf599ef20fa4c78d44_3fa3a1fd8193e76ffb7a3caf599ef20fa4c78d44/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.03 seconds
stream load tsv: 535 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17161908635 Bytes

@yiguolei
Copy link
Contributor

yiguolei commented Sep 10, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Sep 10, 2023

TeamCity be ut coverage result:
Function Coverage: 36.94% (7911/21413)
Line Coverage: 28.96% (63547/219434)
Region Coverage: 27.89% (32992/118279)
Branch Coverage: 24.46% (16947/69276)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d7ffcbff8f3655e05ea65d83981e7a89b306ecd7_d7ffcbff8f3655e05ea65d83981e7a89b306ecd7/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 10, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.27 seconds
stream load tsv: 581 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162451628 Bytes

wm1581066
wm1581066 approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@wm1581066 wm1581066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yiguolei
yiguolei approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 32a7eef into apache:master Sep 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2023
HappenLee added a commit to HappenLee/incubator-doris that referenced this pull request Sep 12, 2023
@HappenLee @yiguolei
[schedule](pipeline) Remove wait schedule time in pipeline query engi…
2269d28 
…ne (apache#23994)

Co-authored-by: yiguolei <676222867@qq.com>
yiguolei added a commit that referenced this pull request Sep 12, 2023
@HappenLee @yiguolei
[schedule](pipeline) Remove wait schedule time in pipeline query engi…
686fff6 
…ne (#23994) (#24247)

Co-authored-by: yiguolei <676222867@qq.com>
xiaokang pushed a commit that referenced this pull request Sep 13, 2023
@HappenLee @yiguolei @xiaokang
[schedule](pipeline) Remove wait schedule time in pipeline query engi…
9118053 
…ne (#23994) (#24247)

Co-authored-by: yiguolei <676222867@qq.com>
@xiaokang
Copy link
Contributor

xiaokang commented Sep 14, 2023

#24247

shuke987 added a commit to shuke987/doris that referenced this pull request Sep 15, 2023
@shuke987
Revert "[schedule](pipeline) Remove wait schedule time in pipeline qu…
7b10cbc 
…ery engine (apache#23994)"

This reverts commit 32a7eef.
@shuke987 shuke987 mentioned this pull request Sep 15, 2023
Merged
yiguolei pushed a commit that referenced this pull request Sep 18, 2023
@shuke987
Revert "[schedule](pipeline) Remove wait schedule time in pipeline qu…
591aeaa 
…ery engine (#23994)" (#24472)

This reverts commit 32a7eef.
xiaokang added a commit that referenced this pull request Sep 18, 2023
@xiaokang
Revert "[schedule](pipeline) Remove wait schedule time in pipeline qu…
38493a9 
…ery engine (#23994) (#24247)"

This reverts commit 9118053.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

+2 more reviewers

@shuke987 shuke987 shuke987 approved these changes

@wm1581066 wm1581066 wm1581066 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@HappenLee @doris-robot @yiguolei @xiaokang @shuke987 @wm1581066 @Gabriel39