Skip to content

[feat](stats) enable set auto analyze time by set global session variable #24026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 13, 2023
Merged

[feat](stats) enable set auto analyze time by set global session variable #24026

morrySnow merged 1 commit into from
Sep 13, 2023

Conversation

@Kikyou1997
Copy link
Contributor

@Kikyou1997 Kikyou1997 commented Sep 7, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kikyou1997
Copy link
Contributor Author

Kikyou1997 commented Sep 7, 2023

run buildall

zfr9527
zfr9527 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@zfr9527 zfr9527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 7, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.65 seconds
stream load tsv: 539 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162015126 Bytes

@Kikyou1997 Kikyou1997 force-pushed the feat/support_set_analyze_in_session branch from de0b441 to b3cc4b7 Compare September 7, 2023 11:40
@Kikyou1997
Copy link
Contributor Author

Kikyou1997 commented Sep 7, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 7, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.95 seconds
stream load tsv: 527 seconds loaded 74807831229 Bytes, about 135 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162241100 Bytes

@Kikyou1997 Kikyou1997 force-pushed the feat/support_set_analyze_in_session branch from b3cc4b7 to 281dc3f Compare September 8, 2023 02:13
@Kikyou1997
Copy link
Contributor Author

Kikyou1997 commented Sep 8, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.59 seconds
stream load tsv: 526 seconds loaded 74807831229 Bytes, about 135 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162060339 Bytes

morrySnow
morrySnow requested changes Sep 8, 2023
View reviewed changes
@zfr9527 zfr9527 mentioned this pull request Sep 8, 2023
Closed
@Kikyou1997 Kikyou1997 force-pushed the feat/support_set_analyze_in_session branch 2 times, most recently from 3f994cc to 8ce56cb Compare September 11, 2023 03:00
@Kikyou1997
Copy link
Contributor Author

Kikyou1997 commented Sep 11, 2023

run buildall

1 similar comment
@Kikyou1997
Copy link
Contributor Author

Kikyou1997 commented Sep 11, 2023

run buildall

@Kikyou1997 Kikyou1997 force-pushed the feat/support_set_analyze_in_session branch from 8ce56cb to dd47a25 Compare September 11, 2023 04:11
@Kikyou1997
Copy link
Contributor Author

Kikyou1997 commented Sep 11, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.44 seconds
stream load tsv: 585 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162410050 Bytes

@doris-robot
Copy link

doris-robot commented Sep 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.21 seconds
stream load tsv: 583 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162379390 Bytes

@Kikyou1997 Kikyou1997 force-pushed the feat/support_set_analyze_in_session branch from dd47a25 to a923e95 Compare September 12, 2023 04:09
@Kikyou1997
Copy link
Contributor Author

Kikyou1997 commented Sep 12, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 12, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.77 seconds
stream load tsv: 608 seconds loaded 74807831229 Bytes, about 117 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162545005 Bytes

morrySnow
morrySnow reviewed Sep 12, 2023
View reviewed changes
@Kikyou1997 Kikyou1997 force-pushed the feat/support_set_analyze_in_session branch from a923e95 to 4b8c3c6 Compare September 12, 2023 07:32
@Kikyou1997
Copy link
Contributor Author

Kikyou1997 commented Sep 12, 2023

run buildall

morningman
morningman reviewed Sep 12, 2023
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
description = {"该参数定义自动ANALYZE例程的开始时间",
"This parameter defines the start time for the automatic ANALYZE routine."},
flag = VariableMgr.GLOBAL)
public String fullAutoAnalyzeStartTime = "";
Copy link
Contributor

@morningman morningman Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be in GlobalVariable.java

morningman
morningman approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 13, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.39 seconds
stream load tsv: 598 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162306435 Bytes

@morrySnow morrySnow changed the title [feat](optimizer) enable set auto analyze time by set global session variable [feat](stats) enable set auto analyze time by set global session variable Sep 13, 2023
@morrySnow morrySnow merged commit f205473 into apache:master Sep 13, 2023
@Kikyou1997 Kikyou1997 mentioned this pull request Oct 12, 2023
Merged
morningman pushed a commit that referenced this pull request Oct 13, 2023
@Kikyou1997
[refactor][backport](stats) Migrate stats framework from master to br…
4b6ff32 
…anch 2.0 (#25119)

This PR is composed of belowing commits which has been merged to Doirs master:

* #24769
* #24672
* #24599
* #24521
* #24405
* #24237
* #24135
* #24074
* #24026
* #23992
* #23978
* #23622
* #23507
* #23354
* #23103
* #22963
* #22896
* #22775
* #22773
morningman pushed a commit that referenced this pull request Oct 15, 2023
@Kikyou1997
[branch2.0](backport) Migrate stats framework from master to branch-2…
3daa4cd 
….0 (#25421)

This PR is composed of belowing commits which has been merged to Doirs master:

* #24769
* #24672
* #24599
* #24521
* #24405
* #24237
* #24135
* #24074
* #24026
* #23992
* #23978
* #23622
* #23507
* #23354
* #23103
* #22963
* #22896
* #22775
* #22773

After this PR, when user upgrade Doris from 2.0.2 to 2.0.3, the origin info in AnalysisManager will be ignored, and the new module AnalysisManagerV2 will be saved(with more info).
@morningman morningman mentioned this pull request Oct 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@zfr9527 zfr9527 zfr9527 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Kikyou1997 @doris-robot @morningman @zfr9527 @morrySnow @xiaokang