Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Sep 8, 2023

Proposed changes

create table

create table if not exists sub_query_correlated_subquery1
        (k1 bigint, k2 bigint)
        duplicate key(k1)
        distributed by hash(k2) buckets 1
        properties('replication_num' = '1') ;

create table if not exists sub_query_correlated_subquery3
        (k1 int, k2 varchar(128), k3 bigint, v1 bigint, v2 bigint)
        distributed by hash(k2) buckets 1
        properties('replication_num' = '1');

insert data

insert into sub_query_correlated_subquery1 values (1,null),(null,1),(1,2), (null,2),(1,3), (2,4), 
    (2,5), (3,3), (3,4), (20,2), (22,3), (24,4),(null,null);
insert into sub_query_correlated_subquery3 values (1,"abc",2,3,4), (1,"abcd",3,3,4), (2,"xyz",2,4,2),
    (2,"uvw",3,4,2), (2,"uvw",3,4,2), (3,"abc",4,5,3), (3,"abc",4,5,3), (null,null,null,null,null); 

query

select * from sub_query_correlated_subquery1 where sub_query_correlated_subquery1.k1 not in (
    select sub_query_correlated_subquery3.k3 from sub_query_correlated_subquery3 
)  or k1 < 10 order by k1, k2;

result

Empty set 

Expect result

k1	k2
1	null
1	2
1	3
2	4
2	5
3	3
3	4

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

PR approved by anyone and no changes requested.

@mrhhsg
Copy link
Member Author

mrhhsg commented Sep 8, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.91% (7895/21387)
Line Coverage: 28.92% (63351/219046)
Region Coverage: 27.86% (32891/118054)
Branch Coverage: 24.44% (16890/69094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/545c6901bf541571dfc1a32349816148767e272a_545c6901bf541571dfc1a32349816148767e272a/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.62 seconds
stream load tsv: 544 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162039094 Bytes

@yiguolei
Copy link
Contributor

yiguolei commented Sep 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.92% (7895/21385)
Line Coverage: 28.93% (63361/219040)
Region Coverage: 27.87% (32895/118042)
Branch Coverage: 24.46% (16897/69094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e8e15fb867928c5010e251a674b1422cdfb492d8_e8e15fb867928c5010e251a674b1422cdfb492d8/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.68 seconds
stream load tsv: 527 seconds loaded 74807831229 Bytes, about 135 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162184752 Bytes

@yiguolei
Copy link
Contributor

yiguolei commented Sep 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.92% (7895/21385)
Line Coverage: 28.91% (63335/219040)
Region Coverage: 27.86% (32890/118042)
Branch Coverage: 24.45% (16895/69094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/129229be993636592b708ae818f67264699c438a_129229be993636592b708ae818f67264699c438a/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.28 seconds
stream load tsv: 531 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162245341 Bytes

@mrhhsg
Copy link
Member Author

mrhhsg commented Sep 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.90% (7895/21397)
Line Coverage: 28.91% (63355/219159)
Region Coverage: 27.84% (32882/118117)
Branch Coverage: 24.43% (16891/69146)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f1648f16e29ec00b952c9beb90ddbe4bc281d283_f1648f16e29ec00b952c9beb90ddbe4bc281d283/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.43 seconds
stream load tsv: 545 seconds loaded 74807831229 Bytes, about 130 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161897508 Bytes

@mrhhsg
Copy link
Member Author

mrhhsg commented Sep 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.91% (7897/21397)
Line Coverage: 28.92% (63379/219159)
Region Coverage: 27.86% (32907/118117)
Branch Coverage: 24.44% (16902/69146)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d1d300679c3ee25cb813e6225dad3c61a4bfcbab_d1d300679c3ee25cb813e6225dad3c61a4bfcbab/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.31 seconds
stream load tsv: 544 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162197532 Bytes

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged merge_conflict reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants