Skip to content

[fix](multi-catalog)support bit type and hidden mc secret key #24124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Sep 12, 2023
Merged

[fix](multi-catalog)support bit type and hidden mc secret key #24124

morningman merged 1 commit into from
Sep 12, 2023

Conversation

@wsjz
Copy link
Contributor

@wsjz wsjz commented Sep 8, 2023 •
edited by morningman
Loading

Proposed changes

support max compute bit type and mask mc secret key
bool type will use bit arrow vector
should mask secret key: close #24019

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@wsjz
Copy link
Contributor Author

wsjz commented Sep 9, 2023

run buildall

@wsjz
Copy link
Contributor Author

wsjz commented Sep 9, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 9, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.01 seconds
stream load tsv: 543 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161945319 Bytes

@doris-robot
Copy link

doris-robot commented Sep 9, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.22 seconds
stream load tsv: 544 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161958440 Bytes

@wsjz wsjz mentioned this pull request Sep 9, 2023
Closed
3 tasks
morningman
morningman reviewed Sep 9, 2023
View reviewed changes
...ons/max-compute-scanner/src/main/java/org/apache/doris/maxcompute/MaxComputeColumnValue.java
skippedIfNull();
TinyIntVector tinyIntCol = (TinyIntVector) column;
return tinyIntCol.get(idx++) > 0;
BitVector bitCol = (BitVector) column;
Copy link
Contributor

@morningman morningman Sep 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain why using bitvector here?
and what about tinyint?

Copy link
Contributor Author

@wsjz wsjz Sep 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool type is bind to bit vector
tinyint type bind to tinyint vector, it can work now

Jibing-Li
Jibing-Li approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Jibing-Li Jibing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

PR approved by anyone and no changes requested.

morningman
morningman approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit fca34ec into apache:master Sep 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 12, 2023
xiaokang pushed a commit that referenced this pull request Sep 12, 2023
@wsjz @xiaokang
[fix](multi-catalog)support bit type and hidden mc secret key (#24124)
c36f524 
support max compute bit type and mask mc secret key
bool type will use bit arrow vector
should mask secret key: close #24019
xiaokang pushed a commit that referenced this pull request Sep 13, 2023
@wsjz @xiaokang
[fix](multi-catalog)support bit type and hidden mc secret key (#24124)
9a5bd48 
support max compute bit type and mask mc secret key
bool type will use bit arrow vector
should mask secret key: close #24019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@Jibing-Li Jibing-Li Jibing-Li approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When showing the catalog of max compute, the key did not mask

5 participants

@wsjz @doris-robot @morningman @Jibing-Li @xiaokang