Skip to content

[Fix](clucene) fix clucene build error in arm #24130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zy-kkk merged 1 commit into from
Sep 9, 2023
Merged

[Fix](clucene) fix clucene build error in arm #24130

zy-kkk merged 1 commit into from
Sep 9, 2023

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Sep 9, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@airborne12
Copy link
Member Author

airborne12 commented Sep 9, 2023

run buildall

zy-kkk
zy-kkk approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@zy-kkk zy-kkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

zzzxl1993
zzzxl1993 approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

doris-robot commented Sep 9, 2023

TeamCity be ut coverage result:
Function Coverage: 36.90% (7895/21397)
Line Coverage: 28.91% (63358/219134)
Region Coverage: 27.85% (32887/118097)
Branch Coverage: 24.44% (16894/69134)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5eaf52958ea8754b5da2b6a1ecf99f8be0fe4816_5eaf52958ea8754b5da2b6a1ecf99f8be0fe4816/report/index.html

@doris-robot
Copy link

doris-robot commented Sep 9, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.81 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17161745720 Bytes

@zy-kkk zy-kkk merged commit c3f3195 into apache:master Sep 9, 2023
xiaokang pushed a commit that referenced this pull request Sep 11, 2023
@airborne12 @xiaokang
[Fix](clucene) fix clucene build error in arm (#24130)
1211fcc
xiaokang pushed a commit that referenced this pull request Sep 13, 2023
@airborne12 @xiaokang
[Fix](clucene) fix clucene build error in arm (#24130)
4f42ee4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@airborne12 @doris-robot @zzzxl1993 @zy-kkk @xiaokang