Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Sep 11, 2023

Proposed changes

Check failure stack trace: ***
F20230910 13:58:28.553936  8958 vhash_join_node.cpp:620] Check failed: output_rows <= state->batch_size()

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrhhsg
Copy link
Member Author

mrhhsg commented Sep 11, 2023

run buildall

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@jacktengg jacktengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.66 seconds
stream load tsv: 586 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162403710 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.93% (7919/21441)
Line Coverage: 28.96% (63629/219698)
Region Coverage: 27.89% (33000/118343)
Branch Coverage: 24.46% (16945/69274)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0b856158b6bd73669aedf15c0b68b0262f010ac2_0b856158b6bd73669aedf15c0b68b0262f010ac2/report/index.html

@BiteTheDDDDt BiteTheDDDDt merged commit c94e475 into apache:master Sep 11, 2023
@mrhhsg mrhhsg deleted the fix_join_dcheck branch September 11, 2023 04:01
xiaokang pushed a commit that referenced this pull request Sep 11, 2023
…24162)

avoid DCHECK failed in '_filter_data_and_build_output'
xiaokang pushed a commit that referenced this pull request Sep 13, 2023
…24162)

avoid DCHECK failed in '_filter_data_and_build_output'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants