Skip to content

[fix](invert index) fix clucene compiler warning #24174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 1 commit into from
Sep 11, 2023
Merged

[fix](invert index) fix clucene compiler warning #24174

xiaokang merged 1 commit into from
Sep 11, 2023

Conversation

@zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Sep 11, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Sep 11, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Sep 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.61 seconds
stream load tsv: 588 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162120711 Bytes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

clang-tidy review says "All clean, LGTM! 👍"

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Sep 11, 2023

run beut

@zzzxl1993 zzzxl1993 changed the title [fix](invert index) fix overloaded-virtual compiler warning [fix](invert index) fix clucene compiler warning Sep 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

clang-tidy review says "All clean, LGTM! 👍"

airborne12
airborne12 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 11, 2023

TeamCity be ut coverage result:
Function Coverage: 36.92% (7917/21443)
Line Coverage: 28.95% (63607/219704)
Region Coverage: 27.88% (32994/118346)
Branch Coverage: 24.45% (16938/69272)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ae7f7107f1d4a85212dbea9413d04cfadb58a854_ae7f7107f1d4a85212dbea9413d04cfadb58a854/report/index.html

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Sep 11, 2023

run buildall

qidaye
qidaye approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.83 seconds
stream load tsv: 587 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162159921 Bytes

@doris-robot
Copy link

doris-robot commented Sep 11, 2023

TeamCity be ut coverage result:
Function Coverage: 36.93% (7920/21444)
Line Coverage: 28.96% (63633/219717)
Region Coverage: 27.88% (33003/118358)
Branch Coverage: 24.46% (16947/69280)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ae7f7107f1d4a85212dbea9413d04cfadb58a854_ae7f7107f1d4a85212dbea9413d04cfadb58a854/report/index.html

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Sep 11, 2023

run p0

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Sep 11, 2023

run p1

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Sep 11, 2023

run p0

@xiaokang xiaokang merged commit 11e052c into apache:master Sep 11, 2023
xiaokang pushed a commit that referenced this pull request Sep 11, 2023
@zzzxl1993 @xiaokang
[fix](invert index) fix overloaded-virtual compiler warning (#24174)
076fd7e
xiaokang pushed a commit that referenced this pull request Sep 13, 2023
@zzzxl1993 @xiaokang
[fix](invert index) fix overloaded-virtual compiler warning (#24174)
6c16bb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes

@qidaye qidaye qidaye approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zzzxl1993 @doris-robot @airborne12 @qidaye @xiaokang