Skip to content

[fix](load) check segment file size when finalize #24196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Sep 12, 2023
Merged

[fix](load) check segment file size when finalize #24196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions be/src/olap/rowset/segment_v2/segment_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,11 +904,9 @@ Status SegmentWriter::finalize_footer(uint64_t* segment_file_size) {
// finish
RETURN_IF_ERROR(_file_writer->finalize());
*segment_file_size = _file_writer->bytes_appended();
return Status::OK();
}

Status SegmentWriter::finalize_footer() {
RETURN_IF_ERROR(_write_footer());
if (*segment_file_size == 0) {
return Status::Corruption("Bad segment, file size = 0");
}
return Status::OK();
}

Expand All @@ -925,10 +923,7 @@ Status SegmentWriter::finalize(uint64_t* segment_file_size, uint64_t* index_size
// write index
RETURN_IF_ERROR(finalize_columns_index(index_size));
// write footer
RETURN_IF_ERROR(finalize_footer());
// finish
RETURN_IF_ERROR(_file_writer->finalize());
*segment_file_size = _file_writer->bytes_appended();
RETURN_IF_ERROR(finalize_footer(segment_file_size));

if (timer.elapsed_time() > 5000000000l) {
LOG(INFO) << "segment flush consumes a lot time_ns " << timer.elapsed_time()
Expand Down
1 change: 0 additions & 1 deletion be/src/olap/rowset/segment_v2/segment_writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ class SegmentWriter {
Status finalize_columns_data();
Status finalize_columns_index(uint64_t* index_size);
Status finalize_footer(uint64_t* segment_file_size);
Status finalize_footer();

void init_column_meta(ColumnMetaPB* meta, uint32_t column_id, const TabletColumn& column,
TabletSchemaSPtr tablet_schema);
Expand Down