Fix BE do_tablet_meta_checkpoint retain _meta_lock for a long time #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a flag in RowsetMeta to record whether it has been deleted from rowset meta.
imay
requested changes
Dec 11, 2019
| LOG(INFO) << "remove rowset id from meta store because it is already persistent with tablet meta" | ||
| << ", rowset_id=" << rs_meta->rowset_id(); | ||
| } | ||
| rs_meta->set_remove_from_rowset_meta(); |
Contributor
There was a problem hiding this comment.
It seems that this line of code should be executed in above if clause.
Co-Authored-By: ZHAO Chun <buaa.zhaoc@gmail.com>
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Dec 17, 2019
…pache#2430) Add a flag in RowsetMeta to record whether it has been deleted from rowset meta. Before this PR, 37156 rowsets only cost 1642 s. With this PR, 37319 rowsets just cost 1 s.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Dec 17, 2019
…pache#2430) Add a flag in RowsetMeta to record whether it has been deleted from rowset meta. Before this PR, 37156 rowsets only cost 1642 s. With this PR, 37319 rowsets just cost 1 s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2419
Add a flag in RowsetMeta to record whether it has been deleted from rowset meta.
Before this PR, 37156 rowsets only cost 1642 s.
With this PR, 37319 rowsets just cost 1 s.