Skip to content

[feat](stats) calculate stats health based on real updated rows count #24599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Sep 22, 2023
Merged

[feat](stats) calculate stats health based on real updated rows count #24599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,19 +1127,17 @@ public BaseAnalysisTask createAnalysisTask(AnalysisInfo info) {

@Override
public boolean needReAnalyzeTable(TableStats tblStats) {
long rowCount = getRowCount();
// TODO: Do we need to analyze an empty table?
if (rowCount == 0) {
return false;
if (tblStats == null) {
return true;
}
long rowCount = getRowCount();
if (!tblStats.analyzeColumns().containsAll(getBaseSchema()
.stream()
.map(Column::getName)
.collect(Collectors.toSet()))) {
return true;
}
// long updateRows = tblStats.updatedRows.get();
long updateRows = Math.abs(tblStats.rowCount - rowCount);
long updateRows = tblStats.updatedRows.get();
int tblHealth = StatisticsUtil.getTableHealth(rowCount, updateRows);
return tblHealth < Config.table_stats_health_threshold;
}
Expand Down
1 change: 1 addition & 0 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,6 +987,7 @@ public void updateUpdatedRows(long tblId, long rows) {
TableStats statsStatus = idToTblStats.get(tblId);
if (statsStatus != null) {
statsStatus.updatedRows.addAndGet(rows);
logCreateTableStats(statsStatus);
}
}

Expand Down
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsAutoCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ protected AnalysisInfo getReAnalyzeRequiredPart(AnalysisInfo jobInfo) {
AnalysisManager analysisManager = Env.getServingEnv().getAnalysisManager();
TableStats tblStats = analysisManager.findTableStatsStatus(table.getId());

if (!(tblStats == null || table.needReAnalyzeTable(tblStats))) {
if (!table.needReAnalyzeTable(tblStats)) {
return null;
}

Expand Down
2 changes: 2 additions & 0 deletions fe/fe-core/src/test/java/org/apache/doris/statistics/AnalysisManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,10 @@ public List<Column> getBaseSchema() {
};
OlapTable olapTable = new OlapTable();
TableStats stats1 = new TableStats(0, 50, new AnalysisInfoBuilder().setColName("col1").build());
stats1.updatedRows.addAndGet(30);
Assertions.assertTrue(olapTable.needReAnalyzeTable(stats1));
TableStats stats2 = new TableStats(0, 190, new AnalysisInfoBuilder().setColName("col1").build());
stats2.updatedRows.addAndGet(20);
Assertions.assertFalse(olapTable.needReAnalyzeTable(stats2));

}
Expand Down