[improvement](tablet clone) fix balanced new replica will be removed when load txn continuously #25061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick: #24845
For a new clone replica, its init state is CLONE. During CLONE state, the replica can not load data.
When cloning finishing, check this replica is catchup with the partition. Check new replica's version is not enough. Because replica not write txn during CLONE, when these txns change from prepare to commit or visible, the new replica will be fallbehind (last failed version > 0). Later check this tablet is reduant and the new replica will be removed cause its last failed version > 0.
To fix this, when clone a new replica finished, we should check the txns during CLONE should be finished.
TEST: Let write txn continuously and none-stop, and make be clone a full snapshot cost 20s. Then let balance occur, later the new replica can success cloning after two or three further repair, and the old replica will be removed later.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...