Skip to content

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Oct 7, 2023

Proposed changes

pick: #24845

For a new clone replica, its init state is CLONE. During CLONE state, the replica can not load data.

When cloning finishing, check this replica is catchup with the partition. Check new replica's version is not enough. Because replica not write txn during CLONE, when these txns change from prepare to commit or visible, the new replica will be fallbehind (last failed version > 0). Later check this tablet is reduant and the new replica will be removed cause its last failed version > 0.

To fix this, when clone a new replica finished, we should check the txns during CLONE should be finished.

TEST: Let write txn continuously and none-stop, and make be clone a full snapshot cost 20s. Then let balance occur, later the new replica can success cloning after two or three further repair, and the old replica will be removed later.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yujun777
Copy link
Contributor Author

yujun777 commented Oct 7, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.99 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 36.7 seconds inserted 10000000 Rows, about 272K ops/s
storage size: 17164461513 Bytes

@yujun777 yujun777 force-pushed the branch-2.0-impr-tablet-clone branch from de210b0 to e9e3d69 Compare October 8, 2023 02:20
@yujun777
Copy link
Contributor Author

yujun777 commented Oct 8, 2023

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.43 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17163298941 Bytes

@dataroaring dataroaring merged commit 21026a5 into apache:branch-2.0 Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants