Skip to content

[enhancement](merge-on-write) refine tablet meta_lock usage and add some trace log #25124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 7 commits into from
Oct 13, 2023
Merged

[enhancement](merge-on-write) refine tablet meta_lock usage and add some trace log #25124

zhannngchen merged 7 commits into from
Oct 13, 2023

Conversation

@zhannngchen
Copy link
Contributor

@zhannngchen zhannngchen commented Oct 8, 2023 •
edited
Loading

Proposed changes

Issue Number: close #xxx

  1. change to read lock while save_meta(), in the method _delete_stale_rowset_by_version.
  2. make TRACE_TABLET_LOCK_THRESHOLD shorter
  3. print detailed trace if update_delete_bitmap takes too long time
  4. return on _load_rowset_segments() error status
  5. print detailed trace if save_meta too slow

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Oct 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

TeamCity be ut coverage result:
Function Coverage: 36.29% (8149/22458)
Line Coverage: 28.42% (65175/229337)
Region Coverage: 27.34% (33769/123501)
Branch Coverage: 24.02% (17210/71648)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d7778b080e56808f721efb4795e1ca8bd0c098be_d7778b080e56808f721efb4795e1ca8bd0c098be/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.83 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162525884 Bytes

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Oct 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

TeamCity be ut coverage result:
Function Coverage: 36.28% (8147/22454)
Line Coverage: 28.41% (65166/229340)
Region Coverage: 27.33% (33754/123494)
Branch Coverage: 24.02% (17210/71644)
Coverage Report: http://coverage.selectdb-in.cc/coverage/916a2d1c2fc0abf717ebc3478e9c1f27456937d7_916a2d1c2fc0abf717ebc3478e9c1f27456937d7/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.82 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162422991 Bytes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen changed the title [enhancement](merge-on-write) refine trace log [enhancement](merge-on-write) refine tablet meta_lock usage and add some trace log Oct 10, 2023
@zhannngchen
Copy link
Contributor Author

zhannngchen commented Oct 10, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 10, 2023

TeamCity be ut coverage result:
Function Coverage: 36.28% (8149/22459)
Line Coverage: 28.43% (65191/229298)
Region Coverage: 27.36% (33777/123473)
Branch Coverage: 24.03% (17210/71616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3e51d154dc763369fb1be63f42870369c9018caf_3e51d154dc763369fb1be63f42870369c9018caf/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 10, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.87 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161964924 Bytes

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Oct 10, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 10, 2023

TeamCity be ut coverage result:
Function Coverage: 36.31% (8149/22445)
Line Coverage: 28.44% (65195/229262)
Region Coverage: 27.36% (33780/123449)
Branch Coverage: 24.04% (17212/71608)
Coverage Report: http://coverage.selectdb-in.cc/coverage/771def7da86cf64964078fb0912ac88a143194a8_771def7da86cf64964078fb0912ac88a143194a8/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 10, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.18 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162191719 Bytes

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Oct 12, 2023

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit fc40788 into apache:master Oct 13, 2023
@hello-stephen hello-stephen mentioned this pull request Oct 13, 2023
Merged
zhangstar333 pushed a commit that referenced this pull request Oct 13, 2023
@hello-stephen
[chore](format) fix tablet_meta.cpp (#25410)
9f67bcf 
fix format error introduced by #25124
The clang format check had a bug before, so PR 25124 can pass the check at that time.
xiaokang pushed a commit that referenced this pull request Oct 13, 2023
@zhannngchen @xiaokang
[enhancement](merge-on-write) refine tablet meta_lock usage and add s…
3bc4fed 
…ome trace log (#25124)
xiaokang pushed a commit that referenced this pull request Oct 16, 2023
@hello-stephen @xiaokang
[chore](format) fix tablet_meta.cpp (#25410)
01bca9d 
fix format error introduced by #25124
The clang format check had a bug before, so PR 25124 can pass the check at that time.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@zhannngchen
[enhancement](merge-on-write) refine tablet meta_lock usage and add s…
107b9fe 
…ome trace log (apache#25124)
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@hello-stephen
[chore](format) fix tablet_meta.cpp (apache#25410)
0f6092e 
fix format error introduced by apache#25124
The clang format check had a bug before, so PR 25124 can pass the check at that time.
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@hello-stephen
[chore](format) fix tablet_meta.cpp (apache#25410)
8e96f66 
fix format error introduced by apache#25124
The clang format check had a bug before, so PR 25124 can pass the check at that time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhannngchen @doris-robot @liaoxin01 @dataroaring @xiaokang