Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Oct 8, 2023

Proposed changes

extend min-max rf to support 3 types:

  1. n<A
  2. m>A
  3. n<A<m,
    in which m/n are constants and A is column.
    this pr only contains thrift definition.

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@englefly
Copy link
Contributor Author

englefly commented Oct 8, 2023

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.63 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162244010 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@englefly englefly merged commit febc5ed into apache:master Oct 9, 2023
xiaokang pushed a commit that referenced this pull request Oct 11, 2023
extend min-max rf to support 3 types:

n<A
m>A
n<A<m,
in which m/n are constants and A is column.
this pr only contains thrift definition.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
extend min-max rf to support 3 types:

n<A
m>A
n<A<m,
in which m/n are constants and A is column.
this pr only contains thrift definition.
@englefly englefly deleted the nlj-rf branch March 27, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants