-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](Nereids) covert predicate to SARGABLE #25180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
e3f134d to
4debe46
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
4debe46 to
068eaf6
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
819737b to
3fbe33f
Compare
|
run buildall |
3fbe33f to
9b5b1c2
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
9b5b1c2 to
50995c1
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
| public Expression visitLessThanEqual(LessThanEqual lessThanEqual, ExpressionRewriteContext context) { | ||
| return process(lessThanEqual); | ||
| // Ensure that the second child must be Literal, such as | ||
| private @Nullable ComparisonPredicate normalize(ComparisonPredicate comparison) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to make it public, because we could use it to generate more effecient Runtime filter.
PostProcessor need this function
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
covert predicate to SARGABLE 1. support format like `1 - a` 2. support rearrange `year/month/week/day/minutes/seconds_sub/add` function
…e wrong result because SimplifyArithmeticComparisonRule (apache#44725) fix months_add/ months_sub/ years_add/years_sub compute wrong result because SimplifyArithmeticComparisonRule introduced by apache#25180 (cherry picked from commit 1ae91b8)
…e wrong result because SimplifyArithmeticComparisonRule (apache#44725) fix months_add/ months_sub/ years_add/years_sub compute wrong result because SimplifyArithmeticComparisonRule introduced by apache#25180 (cherry picked from commit 1ae91b8)
Proposed changes
covert predicate to sargable
1 - ayear/month/week/day/minutes/seconds_sub/addfunctionFurther comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...