Support NULLS LAST and NULLS FIRST syntax #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Update this commit |
Contributor
Author
|
I have updated the commit message, please review, thanks. |
Allow User specify the null ordering NULLS FIRST: specifies that NULL values should be returned before non-NULL values. NULLS LAST: specifies that NULL values should be returned after non-NULL values.
kangkaisen
changed the title
imay
reviewed
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when select * from table order by a,b,c desc, the NULL value will be first. In real application, the users maybe want to the NULL value always be last or first. So，we should support NULLS LAST and NULLS FIRST grammar like Impala and Oracle.
In fact, Doris BE has supported NULLS LAST and NULLS FIRST, we only need to make Doris FE support NULLS LAST and NULLS FIRST.