[coverage](test) Delete unused function to improve test coverage #25233
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return !config::disable_storage_page_cache && | ||
| (_query_options.__isset.enable_page_cache && _query_options.enable_page_cache); | ||
| } | ||
| bool enable_page_cache() const; |
There was a problem hiding this comment.
warning: function 'enable_page_cache' should be marked [[nodiscard]] [modernize-use-nodiscard]
| bool enable_page_cache() const; | |
| [[nodiscard]] bool enable_page_cache() const; |
|
TeamCity be ut coverage result: |
|
run buildall |
| #include <cstring> | ||
| #include <vector> | ||
|
|
||
| #include "cctz/civil_time.h" |
There was a problem hiding this comment.
warning: 'cctz/civil_time.h' file not found [clang-diagnostic-error]
#include "cctz/civil_time.h"
^
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
5 participants
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...