[fix](load) handle Status in beta rowset writer #25293
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
|
||
| if (_segcompaction_worker.get_file_writer()) { | ||
| static_cast<void>(_segcompaction_worker.get_file_writer()->close()); | ||
| WARN_IF_ERROR(_segcompaction_worker.get_file_writer()->close(), |
There was a problem hiding this comment.
Printing a warning here would not be enough. Since data may not be synced to disk if file writers close fail, causing data corruption in silence. I suggest we should return nullptr if shit happens.
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
5 participants
Proposed changes
Handle
Statusreturned from subroutine in beta rowset writer.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...