-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](resource-tag) limit the default user's resource tag to 'default' #25331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](resource-tag) limit the default user's resource tag to 'default' #25331
Conversation
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
zddr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
wangbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…'default' (#25331) In previous, if user property `'resource_tags.location'` is not set, the can use Backends with any resource tag. It may confuse that when the DBA set part of Backends to resource group A, then the current existing user should not be able to use this group A util it's `'resource_tags.location'` is set. So in this PR, I change the behavior, that if user property `'resource_tags.location'` is not set, it can only use the Backends with `default` tag.
…'default' (apache#25331) In previous, if user property `'resource_tags.location'` is not set, the can use Backends with any resource tag. It may confuse that when the DBA set part of Backends to resource group A, then the current existing user should not be able to use this group A util it's `'resource_tags.location'` is set. So in this PR, I change the behavior, that if user property `'resource_tags.location'` is not set, it can only use the Backends with `default` tag.
…efault (#28088) In #25331, I change the behavior of user's default resource tag, that is, if a user does not set resource tag, it can only use default resource tag. This PR change this logic. The normal user can only use default resource tag if resource tag is not set, but root and admin user can use any resource tag if resource tag is not set.
…'default' (apache#25331) In previous, if user property `'resource_tags.location'` is not set, the can use Backends with any resource tag. It may confuse that when the DBA set part of Backends to resource group A, then the current existing user should not be able to use this group A util it's `'resource_tags.location'` is set. So in this PR, I change the behavior, that if user property `'resource_tags.location'` is not set, it can only use the Backends with `default` tag.
…efault (apache#28088) In apache#25331, I change the behavior of user's default resource tag, that is, if a user does not set resource tag, it can only use default resource tag. This PR change this logic. The normal user can only use default resource tag if resource tag is not set, but root and admin user can use any resource tag if resource tag is not set.
Proposed changes
In previous, if user property
'resource_tags.location'is not set, the can use Backends with any resource tag.It may confuse that when the DBA set part of Backends to resource group A, then the current existing user
should not be able to use this group A util it's
'resource_tags.location'is set.So in this PR, I change the behavior, that if user property
'resource_tags.location'is not set, it can only use theBackends with
defaulttag.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...