Skip to content

[fix](Nereids) fix some case error in nereids_syntax_p0 #25341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaokang merged 6 commits into from
Oct 13, 2023
Merged

[fix](Nereids) fix some case error in nereids_syntax_p0 #25341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90b49ab
fix 2.0 case error
keanji-x Oct 12, 2023
1ee1f2f
Update bind_priority.groovy
keanji-x Oct 12, 2023
82614ba
Update bind_priority.groovy
keanji-x Oct 12, 2023
6700292
Update join_subquery_to_apply.out
keanji-x Oct 12, 2023
22fc0a3
Update cast.groovy
keanji-x Oct 12, 2023
2022206
Update bind_priority.groovy
keanji-x Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions regression-test/data/nereids_syntax_p0/push_filter_through_ptopn.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ PhysicalResultSink
-- !3 --
PhysicalResultSink
--PhysicalDistribute
----filter((T.b = 2) and (rn <= 2))
----filter((rn <= 2)(T.b = 2))
------PhysicalWindow
--------PhysicalQuickSort
----------PhysicalPartitionTopN
Expand All @@ -42,9 +42,9 @@ PhysicalResultSink
PhysicalResultSink
--PhysicalDistribute
----PhysicalProject
------filter((T.b = 2) and (rn <= 2))
------filter((rn <= 2)(T.b = 2))
--------PhysicalWindow
----------PhysicalPartitionTopN
----------PhysicalQuickSort
------------PhysicalDistribute
--------------PhysicalPartitionTopN
----------------PhysicalProject
Expand Down
4 changes: 2 additions & 2 deletions regression-test/suites/nereids_syntax_p0/advance_mv.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ suite("advance_mv") {
createMV("CREATE materialized VIEW mv2 AS SELECT abs(k1)+k2+1 tmp, sum(abs(k2+2)+k3+3) FROM ${tbName2} GROUP BY tmp;")

explain {
sql("SELECT abs(k1)+k2+1 tmp, sum(abs(k2+2)+k3+3) from FROM ${tbName2} GROUP BY tmp;")
sql("SELECT abs(k1)+k2+1 tmp, sum(abs(k2+2)+k3+3) FROM ${tbName2} GROUP BY tmp;")
contains "(mv2)"
}
order_qt_select_star "SELECT abs(k1)+k2+1 tmp, sum(abs(k2+2)+k3+3) from FROM ${tbName2} GROUP BY tmp;"
order_qt_select_star "SELECT abs(k1)+k2+1 tmp, sum(abs(k2+2)+k3+3) FROM ${tbName2} GROUP BY tmp;"

sql "CREATE materialized VIEW mv3 AS SELECT abs(k1)+k2+1 tmp, abs(k2+2)+k3+3 FROM ${tbName2};"
int max_try_secs2 = 60
Expand Down
2 changes: 1 addition & 1 deletion regression-test/suites/nereids_syntax_p0/function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ suite("nereids_function") {
}

test {
sql """select "1" == "123", "%%" == "%%" """
sql """select "1" = "123", "%%" = "%%" """
result([[false, true]])
}

Expand Down