Skip to content

Conversation

@zhannngchen
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

For MoW table, if there's too many versions, the delete bitmap will grow to a very big size, which may cause the tablet meta too big and the save_meta operation too slow.
If the rowset should not promotion according to it's disk size, we should also consider it's version count.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen
Copy link
Contributor Author

run buildall

@hust-hhb
Copy link
Contributor

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.24% (8156/22507)
Line Coverage: 28.34% (65300/230392)
Region Coverage: 27.06% (33819/124993)
Branch Coverage: 23.87% (17251/72258)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cc8fd9041b791dd97168299cc2259ea7122a4378_cc8fd9041b791dd97168299cc2259ea7122a4378/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.06 seconds
stream load tsv: 583 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162460037 Bytes

Copy link
Contributor

@hust-hhb hust-hhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 9cc0e95 into apache:master Oct 13, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 13, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

zhannngchen added a commit to zhannngchen/incubator-doris that referenced this pull request Oct 13, 2023
xiaokang pushed a commit that referenced this pull request Oct 13, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants