[improvement](scanner) Remove the predicate that is always true for the segment #25366
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
| } | ||
|
|
||
| auto pruned_predicates = read_options.column_predicates; | ||
| auto pruned = false; |
be/src/olap/comparison_predicate.h
Outdated
| } | ||
|
|
||
| bool is_always_true(const std::pair<WrapperField*, WrapperField*>& statistic) const override { | ||
| if (statistic.first->is_null()) { |
There was a problem hiding this comment.
add || statistic.second ->is null??
| col_predicates); | ||
| } | ||
|
|
||
| bool ColumnReader::prune_predicates_by_zone_map(std::vector<ColumnPredicate*>& predicates, |
There was a problem hiding this comment.
add a config to disable this
and the prune should only be used in query, not in compaction.
| } | ||
| } | ||
|
|
||
| if (pruned) { |
There was a problem hiding this comment.
add a config to disable this
and the prune should only be used in query, not in compaction.
mrhhsg
force-pushed
the
prune_predicates
branch
from
5ad3dc7 to
2a832ba
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
…he segment (apache#25366) By utilizing the zonemap index of the segment, we can ascertain if a predicate is always true. For example, if the segment’s maximum value is 100 and the predicate is col < 101, then this predicate is always true for this segment.
…he segment (apache#25366) (apache#25427) By utilizing the zonemap index of the segment, we can ascertain if a predicate is always true. For example, if the segment’s maximum value is 100 and the predicate is col < 101, then this predicate is always true for this segment.
…he segment (#25582) * [improvement](scanner) Remove the predicate that is always true for the segment (#25366) (#25427) By utilizing the zonemap index of the segment, we can ascertain if a predicate is always true. For example, if the segment’s maximum value is 100 and the predicate is col < 101, then this predicate is always true for this segment. * [fix](scanner) coredump caused by 'prune_predicates_by_zone_map' (#25555)
…he segment (apache#25366) By utilizing the zonemap index of the segment, we can ascertain if a predicate is always true. For example, if the segment’s maximum value is 100 and the predicate is col < 101, then this predicate is always true for this segment.
…he segment (apache#25366) By utilizing the zonemap index of the segment, we can ascertain if a predicate is always true. For example, if the segment’s maximum value is 100 and the predicate is col < 101, then this predicate is always true for this segment.
5 participants
Proposed changes
By utilizing the zonemap index of the segment, we can ascertain if a predicate is always true. For example, if the segment’s maximum value is 100 and the predicate is col < 101, then this predicate is always true for this segment.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...