Skip to content

Conversation

@JackDrogon
Copy link
Contributor

Proposed changes

Add FE thrift rpc redirect master address

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@JackDrogon
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@deadlinefen deadlinefen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.1 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162005328 Bytes

@dataroaring dataroaring merged commit ffacbe7 into apache:master Oct 13, 2023
@JackDrogon JackDrogon deleted the feature/add_fe_thrift_rpc_redirect_master_address branch October 13, 2023 03:19
xiaokang pushed a commit that referenced this pull request Oct 13, 2023
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…5371)

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants