Skip to content

[fix](planner)isnull predicate can't be safely constant folded in inlineview #25377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starocean999 merged 2 commits into from
Nov 8, 2023
Merged

[fix](planner)isnull predicate can't be safely constant folded in inlineview #25377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2053bb5
[fix](planner)isnull predicate can't be safely constant folded in inl…
starocean999 Nov 6, 2023
1feb7c5
fix failed ut
starocean999 Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/analysis/IsNullPredicate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public Expr getResultValue(boolean forPushDownPredicatesToView) throws AnalysisE
// after outer join
recursiveResetChildrenResult(!forPushDownPredicatesToView);
final Expr childValue = getChild(0);
if (!(childValue instanceof LiteralExpr)) {
if (forPushDownPredicatesToView || !(childValue instanceof LiteralExpr)) {
return this;
}
return childValue instanceof NullLiteral ? new BoolLiteral(!isNotNull) : new BoolLiteral(isNotNull);
Expand Down
6 changes: 5 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/rewrite/FoldConstantsRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.apache.doris.analysis.InformationFunction;
import org.apache.doris.analysis.LiteralExpr;
import org.apache.doris.analysis.NullLiteral;
import org.apache.doris.analysis.SlotRef;
import org.apache.doris.analysis.VariableExpr;
import org.apache.doris.catalog.Env;
import org.apache.doris.catalog.PrimitiveType;
Expand Down Expand Up @@ -124,7 +125,10 @@ public Expr apply(Expr expr, Analyzer analyzer, ExprRewriter.ClauseType clauseTy
return expr;
}
}
return expr.getResultValue(false);
// it may be wrong to fold constant value in inline view
// so pass the info to getResultValue method to let predicate itself
// to decide if it can fold constant value safely
return expr.getResultValue(expr instanceof SlotRef ? false : analyzer.isInlineViewAnalyzer());
}

/**
Expand Down
6 changes: 6 additions & 0 deletions regression-test/suites/query_p0/literal_view/lietral_test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,10 @@ suite("literal_view_test") {
sql "select * from (select null as top) t where top = 5"
result ([])
}

sql """set enable_nereids_planner=false;"""
explain {
sql """ select c.* from ( select a.*, '' x from test_insert a left join test_insert b on true ) c where c.x is null; """
notContains("VEMPTYSET")
}
}