Skip to content

Conversation

@AshinGau
Copy link
Member

Proposed changes

The offset in map type column is int64, but #24810 has put as int32, causing error like:

  what():  [E11] Allocator: Cannot realloc from 4096 to 140737488355328.
	1.  @ 0x000000000eb3d670  Allocator<false, false, false>::throw_bad_alloc(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const  in .../doris/output/be/lib/doris_be
	2.  @ 0x000000000eb3da0a  Allocator<false, false, false>::realloc_impl(void*, unsigned long, unsigned long, unsigned long)  in .../doris/output/be/lib/doris_be
	3.  @ 0x000000000ee28301  doris::vectorized::JniConnector::_fill_column(doris::vectorized::JniConnector::TableMetaAddress&, COW<doris::vectorized::IColumn>::immutable_ptr<doris::vectorized::IColumn>&, std::shared_ptr<doris::vectorized::IDataType const>&, unsigned long)  in .../doris/output/be/lib/doris_be
	4.  @ 0x000000000ee292f5  doris::vectorized::JniConnector::_fill_map_column(doris::vectorized::JniConnector::TableMetaAddress&, COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, std::shared_ptr<doris::vectorized::IDataType const>&, unsigned long)  in .../doris/output/be/lib/doris_be

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@AshinGau
Copy link
Member Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 13, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.87 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161924397 Bytes

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 522faa8 into apache:master Oct 13, 2023
xiaokang pushed a commit that referenced this pull request Oct 13, 2023
The offset in map type column is int64, but #24810 has put as int32, causing error like:
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
The offset in map type column is int64, but apache#24810 has put as int32, causing error like:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants